From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, tglx@linutronix.de,
qais.yousef@arm.com
Subject: [PATCH v2 0/4] sched/fair: Active balancer RT/DL preemption fix
Date: Thu, 15 Aug 2019 15:51:03 +0100 [thread overview]
Message-ID: <20190815145107.5318-1-valentin.schneider@arm.com> (raw)
Vincent's load balance rework [1] got me thinking about how and where we
use rq.nr_running vs rq.cfs.h_nr_running checks, and this lead me to
stare intently at the active load balancer.
I haven't seen it happen (yet), but from reading the code it really looks
like we can have some scenarios where the cpu_stopper ends up preempting
a > CFS class task, since we never actually look at what's the remote rq's
running task.
This series shuffles things around the CFS active load balancer to prevent
this from happening.
- Patch 1 is a freebie cleanup
- Patch 2 is a preparatory code move
- Patch 3 adds h_nr_running checks
- Patch 4 adds a sched class check + detach_one_task() to the active balance
This is based on top of today's tip/sched/core:
a46d14eca7b7 ("sched/fair: Use rq_lock/unlock in online_fair_sched_group")
v1 -> v2:
- (new patch) Added need_active_balance() cleanup
- Tweaked active balance code move to respect existing
sd->nr_balance_failed modifications
- Added explicit checks of active_load_balance()'s return value
- Added an h_nr_running < 1 check before kicking the cpu_stopper
- Added a detach_one_task() call in active_load_balance() when the remote
rq's running task is > CFS
[1]: https://lore.kernel.org/lkml/1564670424-26023-1-git-send-email-vincent.guittot@linaro.org/
Valentin Schneider (4):
sched/fair: Make need_active_balance() return bools
sched/fair: Move active balance logic to its own function
sched/fair: Check for CFS tasks before detach_one_task()
sched/fair: Prevent active LB from preempting higher sched classes
kernel/sched/fair.c | 151 ++++++++++++++++++++++++++++----------------
1 file changed, 95 insertions(+), 56 deletions(-)
--
2.22.0
next reply other threads:[~2019-08-15 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:51 Valentin Schneider [this message]
2019-08-15 14:51 ` [PATCH v2 1/4] sched/fair: Make need_active_balance() return bools Valentin Schneider
2019-08-15 14:51 ` [PATCH v2 2/4] sched/fair: Move active balance logic to its own function Valentin Schneider
2019-10-01 11:36 ` Srikar Dronamraju
2019-10-01 11:48 ` Valentin Schneider
2019-08-15 14:51 ` [PATCH v2 3/4] sched/fair: Check for CFS tasks before detach_one_task() Valentin Schneider
2019-08-15 14:51 ` [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes Valentin Schneider
2019-08-27 12:28 ` Vincent Guittot
2019-08-28 9:46 ` Valentin Schneider
2019-08-29 14:19 ` Vincent Guittot
2019-08-30 15:44 ` Valentin Schneider
2019-10-01 10:29 ` [PATCH v2 0/4] sched/fair: Active balancer RT/DL preemption fix Valentin Schneider
2019-10-01 13:31 ` Juri Lelli
2019-10-01 14:15 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815145107.5318-1-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).