From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLACK,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2D1C3A59C for ; Thu, 15 Aug 2019 18:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 457822086C for ; Thu, 15 Aug 2019 18:23:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nSjDZTSF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732897AbfHOSXu (ORCPT ); Thu, 15 Aug 2019 14:23:50 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34807 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbfHOSXt (ORCPT ); Thu, 15 Aug 2019 14:23:49 -0400 Received: by mail-pg1-f193.google.com with SMTP id n9so1659631pgc.1; Thu, 15 Aug 2019 11:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UGJ7znsjgXZPNBjaXocCfBsTQfoM5wdYdwwm1HiJS4E=; b=nSjDZTSFYJtoY3IowdzIDG6SgmO+5YLGJXfuZMkLnyV0ih89tHRYeFno5akxPfKohF rEea7uXCkvjZUjgoopWssOyh1I6R57AYFmq24pSyyRLuG9bVDqTTJ8BIIZvXQATJ1KAs wM5QMCc0KSQME5vWbYpQ+5kQTkkQdLzIyO6q6wU2BX9NxvIxJ+gsR9hZip25eRr/xGVT xbndVyXl//Rw1HhVeKrSrFTgEWhbXZs9QlyoEcIaSaRK6Xm/4vhnb9l0QcRwtDT3KM6N QWThRYQ/T77OKrSEnajJIFZbYJ74Ar1Ckj6QAst8pOGKtw+dJhr1H5gb0JSCSnFL7OhC q8Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=UGJ7znsjgXZPNBjaXocCfBsTQfoM5wdYdwwm1HiJS4E=; b=tS/T5VcuK+jFgdRImX5SfsbTjQXyJDuUwc7XeJyXhxxWjJa7CvzIkFxDdEkrqmWNm+ W6cL7vGTI55pea0CkR15flnYi1V+MuFvH2A8Z7EXNMlbjf9wg+EmJGhA0akQjt2OUlHK gLBZZ5Wdj/HfrhJ8ALVG7b/KzSeMsMN16O5IAje2kwQmLsnwRyFjak9rpS+X+EqBeEwE /irnRTJZY7KGFy7KNeBOtRJJOqP2aZ8qr6pJIMpUbHq6OXA8p3XQYy2j5OQQxt2JBZxZ LmDOHuW/G9v3hhyMsAK5AKBmfpzcQw8FSJy94hPhfwyxbCbIMY9TSysdAGV9mS33pDGL tWFw== X-Gm-Message-State: APjAAAXfxX20F+3C+LFdSOxA2vt4CS6aRIutH5IdXqf7+5TQhfisxZo6 TIe3fOkYEJh+Y0iBXHyYi3A= X-Google-Smtp-Source: APXvYqyxIfMSJIu0Up2QfO88l8rSt/3hO9pZbeZoYF2SLpc/aGJBx6bYgY+YoFe2iJ7cH0z1jneVXg== X-Received: by 2002:aa7:81d9:: with SMTP id c25mr6868327pfn.255.1565893429265; Thu, 15 Aug 2019 11:23:49 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k22sm3423926pfk.157.2019.08.15.11.23.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Aug 2019 11:23:48 -0700 (PDT) Date: Thu, 15 Aug 2019 11:23:47 -0700 From: Guenter Roeck To: Andrey Smirnov Cc: linux-watchdog@vger.kernel.org, Chris Healy , Rick Ramstetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 18/22] watchdog: ziirave_wdt: Fix RESET_PROCESSOR payload Message-ID: <20190815182347.GN14388@roeck-us.net> References: <20190812200906.31344-1-andrew.smirnov@gmail.com> <20190812200906.31344-19-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190812200906.31344-19-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 12, 2019 at 01:09:02PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for > RESET_PROCESSOR: > > S Addr Wr [A] 0x0b [A] 0x01 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x0b [A] 0x01 [A] 0x01 [A] P > > which happens to work because firmware will ignore any extra bytes and > expected magic value matches byte count sent by > i2c_smbus_write_block_data(). Fix this by converting the code to use > i2c_smbus_write_byte_data() instead. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Guenter Roeck