From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: John Keeping <john@metanate.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] perf unwind: fix libunwind when tid != pid
Date: Fri, 16 Aug 2019 12:30:46 -0300 [thread overview]
Message-ID: <20190816153046.GA22547@kernel.org> (raw)
In-Reply-To: <20190815141035.GJ30356@krava>
Em Thu, Aug 15, 2019 at 04:10:35PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 15, 2019 at 11:01:45AM +0100, John Keeping wrote:
> > Commit e5adfc3e7e77 ("perf map: Synthesize maps only for thread group
> > leader") changed the recording side so that we no longer get mmap events
> > for threads other than the thread group leader (when synthesising these
> > events for threads which exist before perf is started).
> >
> > When a file recorded after this change is loaded, the lack of mmap
> > records mean that unwinding is not set up for any other threads.
> >
> > This can be seen in a simple record/report scenario:
> >
> > perf record --call-graph=dwarf -t $TID
> > perf report
> >
> > If $TID is a process ID then the report will show call graphs, but if
> > $TID is a secondary thread the output is as if --call-graph=none was
> > specified.
>
> great, mucch clearler now
>
> >
> > Following the rationale in that commit, move the libunwind fields into
> > struct map_groups and update the libunwind functions to take this
> > instead of the struct thread. This is only required for
> > unwind__finish_access which must now be called from map_groups__delete
> > and the others are changed for symmetry.
> >
> > Note that unwind__get_entries keeps the thread argument since it is
> > required for symbol lookup and the libdw unwind provider uses the thread
> > ID.
> >
> > Fixes: e5adfc3e7e77 ("perf map: Synthesize maps only for thread group leader")
>
> for all 3 patches
>
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2019-08-16 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 17:24 [PATCH 1/2] perf map: use zalloc for map_groups John Keeping
2019-07-29 17:24 ` [PATCH 2/2] perf unwind: fix libunwind when tid != pid John Keeping
2019-08-02 13:30 ` Jiri Olsa
2019-08-04 11:44 ` John Keeping
2019-08-15 10:01 ` [PATCH v2 1/3] perf map: use zalloc for map_groups John Keeping
2019-08-15 10:01 ` [PATCH v2 2/3] perf unwind: fix libunwind when tid != pid John Keeping
2019-08-15 14:10 ` Jiri Olsa
2019-08-16 15:30 ` Arnaldo Carvalho de Melo [this message]
2019-08-16 21:00 ` [tip:perf/core] perf unwind: Fix " tip-bot for John Keeping
2019-08-15 10:01 ` [PATCH v2 3/3] perf unwind: remove unnecessary test John Keeping
2019-08-16 21:01 ` [tip:perf/core] perf unwind: Remove " tip-bot for John Keeping
2019-08-16 20:59 ` [tip:perf/core] perf map: Use zalloc for map_groups tip-bot for John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816153046.GA22547@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john@metanate.com \
--cc=jolsa@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).