From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: nick@shmanahar.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, george_davis@mentor.com
Subject: Re: [PATCH v1 41/63] Input: touchscreen: Atmel: Enable IRQ_DISABLE_UNLAZY flag for interrupt
Date: Fri, 16 Aug 2019 10:26:15 -0700 [thread overview]
Message-ID: <20190816172615.GJ121898@dtor-ws> (raw)
In-Reply-To: <20190816083558.19189-2-jiada_wang@mentor.com>
On Fri, Aug 16, 2019 at 05:35:36PM +0900, Jiada Wang wrote:
> From: Bhuvanesh Surachari <bhuvanesh_surachari@mentor.com>
>
> The de-/serializer driver has defined only irq_mask "ds90ub927_irq_mask" and
> irq_unmask "ds90ub927_irq_unmask" callback functions. And de-/serializer
> driver doesn't implement the irq_disable and irq_enable callback functions.
> Hence inorder to invoke irq_mask callback function when disable_irq_nosync is
> called the IRQ_DISABLE_UNLAZY interrupt flag should be set. If not the
> disable_irq_nosync will just increment the depth field in the irq
> descriptor only once as shown below.
>
> disable_irq_nosync
> __disable_irq_nosync
> __disable_irq (desc->depth++)
> irq_disable
> if irq_disable present -----------> if IRQ_DISABLE_UNLAZYflag set
> | no |
> yes | yes |
> | |
> desc->irq_data.chip->irq_disable desc->irq_data.chip->irq_unmask
> (ds90ub927_irq_mask)
> disable_irq
> __disable_irq_nosync
> __disable_irq
> (desc->depth++)
> But the enable_irq will try to decrement the depth field twice which generates
> the backtrace stating "Unbalanced enable for irq 293". This is because there is
> no IRQ_DISABLE_UNLAZY flag check while calling irq_unmask callback function
> of the "ds90ub927_irq_unmask" de-/serializer via enable_irq.
>
> enable_irq
> __enable_irq (desc->depth--)
> irq_enable
> if irq_enable present -------------> desc->irq_data.chip->irq_unmask
> | no (ds90ub927_irq_unmask)
> yes | enable_irq
> | __enable_irq (desc->depth--)
> (desc->irq_data.chip->irq_enable)
I'd prefer if we instead did not use the disable_irq_nosync() in the
driver.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-08-16 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 8:35 [PATCH v1 40/63] input: atmel_mxt_ts: Add Missing Delay for reset handling of Atmel touch panel controller in detachable displays Jiada Wang
2019-08-16 8:35 ` [PATCH v1 41/63] Input: touchscreen: Atmel: Enable IRQ_DISABLE_UNLAZY flag for interrupt Jiada Wang
2019-08-16 17:26 ` Dmitry Torokhov [this message]
2019-08-22 6:25 ` Jiada Wang
2019-08-16 8:35 ` [PATCH v2 42/63] Input: atmel_mxt_ts: Limit the max bytes transferred in an i2c transaction Jiada Wang
2019-08-16 8:35 ` [PATCH v1 43/63] Input: atmel_mxt_ts: update stale use_retrigen_workaround flag Jiada Wang
2019-08-16 8:35 ` [PATCH v1 44/63] Input: atmel_mxt_ts: return error from mxt_process_messages_until_invalid() Jiada Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816172615.GJ121898@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=george_davis@mentor.com \
--cc=jiada_wang@mentor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).