From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC28CC3A589 for ; Sun, 18 Aug 2019 17:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D7722086C for ; Sun, 18 Aug 2019 17:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cwMKV/Q6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbfHRRr1 (ORCPT ); Sun, 18 Aug 2019 13:47:27 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49926 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfHRRr1 (ORCPT ); Sun, 18 Aug 2019 13:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mD1gjFdZeddiT1lyKp4zbNta586P6sG7Wqwm56zb/+M=; b=cwMKV/Q6FbyRV+Q4pjP4jU6SQ bD4hwrBEbAdfkZuMb6Si+KorGu2u+uRQpnLID6Nlv394avOs58QdPY6/7PmFEZX5MiB7b3GKnQDb9 9XI4JzoHO6cA7VND75mnlARaUv1kYqsP6m8Hx+TowvJbMeSgvnNqaZ2A4eD1Ap461Q5tAiyEfi4Hg GYuoB9f/O1dW+wlwuNZsy0BoRMDqHdwthV/4EWgLFroGr8it1xiExbC8zJhzuxwumuo8B7lTACgQ/ xE+dPGureFbXv5+EPX2+mwRkHxNSqdhShW8dpaQ6JbwmizbGPdwF4TWKC73X9HuHuQn5OpOY+FACS KhZd8MclA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hzPGg-0004ac-SC; Sun, 18 Aug 2019 17:47:02 +0000 Date: Sun, 18 Aug 2019 10:47:02 -0700 From: Christoph Hellwig To: Christoph Hellwig , "Theodore Y. Ts'o" , Richard Weinberger , Greg Kroah-Hartman , Gao Xiang , Jan Kara , Chao Yu , Dave Chinner , David Sterba , Miao Xie , devel , Stephen Rothwell , Darrick , Amir Goldstein , linux-erofs , Al Viro , Jaegeuk Kim , linux-kernel , Li Guifu , Fang Wei , Pavel Machek , linux-fsdevel , Andrew Morton , torvalds Subject: Re: [PATCH] erofs: move erofs out of staging Message-ID: <20190818174702.GA17633@infradead.org> References: <1405781266.69008.1566116210649.JavaMail.zimbra@nod.at> <20190818084521.GA17909@hsiangkao-HP-ZHAN-66-Pro-G1> <1133002215.69049.1566119033047.JavaMail.zimbra@nod.at> <20190818090949.GA30276@kroah.com> <790210571.69061.1566120073465.JavaMail.zimbra@nod.at> <20190818151154.GA32157@mit.edu> <20190818155812.GB13230@infradead.org> <20190818161638.GE1118@sol.localdomain> <20190818162201.GA16269@infradead.org> <20190818172938.GA14413@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190818172938.GA14413@sol.localdomain> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 18, 2019 at 10:29:38AM -0700, Eric Biggers wrote: > Not sure what you're even disagreeing with, as I *do* expect new filesystems to > be held to a high standard, and to be written with the assumption that the > on-disk data may be corrupted or malicious. We just can't expect the bar to be > so high (e.g. no bugs) that it's never been attained by *any* filesystem even > after years/decades of active development. If the developers were careful, the > code generally looks robust, and they are willing to address such bugs as they > are found, realistically that's as good as we can expect to get... Well, the impression I got from Richards quick look and the reply to it is that there is very little attempt to validate the ondisk data structure and there is absolutely no priority to do so. Which is very different from there is a bug or two here and there.