From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A86C3A59B for ; Mon, 19 Aug 2019 07:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E49D2184E for ; Mon, 19 Aug 2019 07:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201096; bh=YYr+sOzCSeA4C3uJqftbtG0MGcaU4L5Jif35BaA4Eeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SX5xSxGugJCEZZ0eFkpYPD2t+yr/PGBTcy8yziOYmazLBoLVi+uZUmDKP7xkpXL1Y AhEMvJUuRa6naLY4sHrqVJcwngqdCAFPswETDmh2Gep2BQKr3LVPbn3ddNmsqK8E+5 aaD3cF21m/G7xPUkGdAoVs21jwvAU5gXUaD8l70U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726888AbfHSHvf (ORCPT ); Mon, 19 Aug 2019 03:51:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:36162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbfHSHvf (ORCPT ); Mon, 19 Aug 2019 03:51:35 -0400 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 119D92082C; Mon, 19 Aug 2019 07:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201094; bh=YYr+sOzCSeA4C3uJqftbtG0MGcaU4L5Jif35BaA4Eeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XkPMjR9kuQYoRQFea2vw8zhFvepVrwta4FDt0MBDl3vuCiPOXC9CX+uxyms8h9ObM lVnSTdfyABWFjGSXGqiaA7jEMJha02Ui/xq8ZZldXeCRmhMMnlHr8KDrN1Yxy+kBPk P3spAEPt2fVETl5G5eZQoUISn2kecFpSHI+5s3Zs= Date: Mon, 19 Aug 2019 09:51:22 +0200 From: Shawn Guo To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: linux-kernel@vger.kernel.org, Ilya Ledvich , Igor Grinberg , Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again Message-ID: <20190819075121.GE5999@X250> References: <20190809031227.3319-1-git@andred.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190809031227.3319-1-git@andred.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 09, 2019 at 04:12:27AM +0100, André Draszik wrote: > Recent changes to the atheros at803x driver caused > ethernet to stop working on this board. > In particular commit 6d4cd041f0af > ("net: phy: at803x: disable delay only for RGMII mode") > and commit cd28d1d6e52e > ("net: phy: at803x: Disable phy delay for RGMII mode") > fix the AR8031 driver to configure the phy's (RX/TX) > delays as per the 'phy-mode' in the device tree. > > This now prevents ethernet from working on this board. > > It used to work before those commits, because the > AR8031 comes out of reset with RX delay enabled, and > the at803x driver didn't touch the delay configuration > at all when "rgmii" mode was selected, and because > arch/arm/mach-imx/mach-imx7d.c:ar8031_phy_fixup() > unconditionally enables TX delay. > > Since above commits ar8031_phy_fixup() also has no > effect anymore, and the end-result is that all delays > are disabled in the phy, no ethernet. > > Update the device tree to restore functionality. > > Signed-off-by: André Draszik > CC: Ilya Ledvich > CC: Igor Grinberg > CC: Rob Herring > CC: Mark Rutland > CC: Shawn Guo > CC: Sascha Hauer > CC: Pengutronix Kernel Team > CC: Fabio Estevam > CC: NXP Linux Team > CC: devicetree@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org Applied, thanks.