From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE25C3A5A0 for ; Mon, 19 Aug 2019 12:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E5CA2085A for ; Mon, 19 Aug 2019 12:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfHSMtp (ORCPT ); Mon, 19 Aug 2019 08:49:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56412 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727039AbfHSMtp (ORCPT ); Mon, 19 Aug 2019 08:49:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7C923091D73; Mon, 19 Aug 2019 12:49:44 +0000 (UTC) Received: from localhost (ovpn-8-19.pek2.redhat.com [10.72.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8BFE1871FB; Mon, 19 Aug 2019 12:49:41 +0000 (UTC) From: Ming Lei To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Ming Lei , Jens Axboe , Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, Jon Derrick Subject: [PATCH V6 0/2] genriq/affinity: Make vectors allocation fair Date: Mon, 19 Aug 2019 20:49:35 +0800 Message-Id: <20190819124937.9948-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 19 Aug 2019 12:49:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, The 1st patch makes __irq_build_affinity_masks() more reliable, such as, all nodes can be covered in the spread. The 2nd patch spread vectors on node according to the ratio of this node's CPU number to number of all remaining CPUs, then vectors assignment can become more fair. Meantime, the warning report from Jon Derrick can be fixed. Please consider it for V5.4. V6: - fix build waring reported by zero day, and extra change is only done on irq_build_affinity_masks() V5: - remove patch 1 of V4, which is wrong - handle vector wrapping because the 'start vector' may begin anywhere, especially for the 2nd stage spread - add more comment on the vector allocation algorithm - cleanup code a bit - run more tests to verify the change, which always get the expected result. Covers lots of num_queues, numa topo, CPU unpresent setting. V4: - provide proof why number of allocated vectors for each node is <= CPU count of this node V3: - re-order the patchset - add helper of irq_spread_vectors_on_node() - handle vector spread correctly in case that numvecs is > ncpus - return -ENOMEM to API's caller V2: - add patch3 - start to allocate vectors from node with minimized CPU number, then every node is guaranteed to be allocated at least one vector. - avoid cross node spread Ming Lei (2): genirq/affinity: Improve __irq_build_affinity_masks() genirq/affinity: Spread vectors on node according to nr_cpu ratio kernel/irq/affinity.c | 231 ++++++++++++++++++++++++++++++++++++------ 1 file changed, 201 insertions(+), 30 deletions(-) Cc: Jens Axboe Cc: Christoph Hellwig Cc: Keith Busch Cc: linux-nvme@lists.infradead.org, Cc: Jon Derrick -- 2.20.1