From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB3AC3A5A2 for ; Mon, 19 Aug 2019 17:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0228C22CEB for ; Mon, 19 Aug 2019 17:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566235820; bh=nIQjZ2Ngwv1FNYTUp1xA+0S/fpXixMWpFc8P4Bcvgp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C3HR0mET6ILOx/lqlBdQZpvyBsAcuVxDZLxdpTJtBpiA/Tm1KTo4vyl2jxYIcrdfg efi0QD+aEDR1b95jB983+D0CVFedb1JO00THAlRs0bnta0G7MVl6jTNEKODvCqDeD/ Pjy8TYbhajgBATUSPCLTpRMyf+ymr0pODiGhQ43w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728163AbfHSRaT (ORCPT ); Mon, 19 Aug 2019 13:30:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:60694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbfHSRaS (ORCPT ); Mon, 19 Aug 2019 13:30:18 -0400 Received: from localhost (unknown [122.182.221.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 148B522CE8; Mon, 19 Aug 2019 17:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566235817; bh=nIQjZ2Ngwv1FNYTUp1xA+0S/fpXixMWpFc8P4Bcvgp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uPMUzus6Ecphk0zdcfgfipVkpjCioZqM89uX5X3qh+SKlR3jbj1b/3quN+TZE/74i uFEvBZPVXG5iLR+MWAaX9UsG2kKnriKPvgoRT1wjRX6++YVQtO8H+PNsWSZm2wpXfY /51vtsJpX2C4GbxySy/5YHCjVgK4SGT10d8S1yKg= Date: Mon, 19 Aug 2019 22:58:59 +0530 From: Vinod Koul To: Stephen Boyd Cc: Andy Gross , linux-arm-msm@vger.kernel.org, Bjorn Andersson , sibis@codeaurora.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/22] arm64: dts: qcom: pm8150: Add Base DTS file Message-ID: <20190819172859.GI12733@vkoul-mobl.Dlink> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-7-vkoul@kernel.org> <20190814170309.0EF3D21721@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814170309.0EF3D21721@mail.kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-08-19, 10:03, Stephen Boyd wrote: > Quoting Vinod Koul (2019-08-14 05:49:56) > > Add base DTS file for pm8150 along with GPIOs > > > > Signed-off-by: Vinod Koul > > --- > > arch/arm64/boot/dts/qcom/pm8150.dtsi | 41 ++++++++++++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi > > new file mode 100644 > > index 000000000000..b533e254a203 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi > > @@ -0,0 +1,41 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. > > +// Copyright (c) 2019, Linaro Limited > > + > > +#include > > +#include > > + > > +&spmi_bus { > > + pm8150_0: pm8150@0 { > > I think node name should be 'pmic' Yes will fix. > > > + compatible = "qcom,spmi-pmic"; > > This should also have the model number? "qcom,pm8150"? Added now > > + reg = <0x0 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pm8150_gpios: gpio@c000 { > > + compatible = "qcom,pm8150-gpio"; > > + reg = <0xc000>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>, > > + <0 0xc1 0 IRQ_TYPE_NONE>, > > + <0 0xc2 0 IRQ_TYPE_NONE>, > > + <0 0xc3 0 IRQ_TYPE_NONE>, > > + <0 0xc4 0 IRQ_TYPE_NONE>, > > + <0 0xc5 0 IRQ_TYPE_NONE>, > > + <0 0xc6 0 IRQ_TYPE_NONE>, > > + <0 0xc7 0 IRQ_TYPE_NONE>, > > + <0 0xc8 0 IRQ_TYPE_NONE>, > > + <0 0xc9 0 IRQ_TYPE_NONE>, > > + <0 0xca 0 IRQ_TYPE_NONE>, > > + <0 0xcb 0 IRQ_TYPE_NONE>; > > + }; > > + }; > > + > > + qcom,pm8150@1 { > > Same comment, pmic@1. right, here and everywhere else -- ~Vinod