From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69587C3A5A0 for ; Tue, 20 Aug 2019 01:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19CFE22CE8 for ; Tue, 20 Aug 2019 01:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Synaptics.onmicrosoft.com header.i=@Synaptics.onmicrosoft.com header.b="DkRCG5r5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728876AbfHTBv4 (ORCPT ); Mon, 19 Aug 2019 21:51:56 -0400 Received: from mail-eopbgr820078.outbound.protection.outlook.com ([40.107.82.78]:1920 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728647AbfHTBvz (ORCPT ); Mon, 19 Aug 2019 21:51:55 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ak4dIrMwIxHAQRkwI8EICZNWfaJx0uKosS/wWNNPzGgm2/bBIckHMZeLA8HQvMWkWGlzIDqOJdUXOjfX+P2gzfgXdi6KRRc6Gh0aZkREddL8CTPB1d7caOoI5RrmbUS1Mzb0IZNwT3Lr1wmC1a1zarRWbcJg9THvfCI+xL/ms8jgh+Lkx6omsLy84eoncUyiE2mxllF6jdnLcjEU9RVZm5wlhK8uyMq+OGrVVuqnOqAdNOHegXFM7E0MwqKcQqsBEOUFXHXU6xycWXCZHEd7I7zMPFv2tU+Ss36MGxOuiWsYrpnrNzvhVFn8h+ciFqrBBVAfvkgn9lIhGqU4A4fAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bpw4V+QcHiY7OKM83+PXT+nZRYTlHkfnTY6HW4l9taQ=; b=dPsjYIDLIXVVKrEFiW1UcG5BVjUYZt8L6bovvYgS9npmrc+yCaRSsbR9PFZei/+XtT+6w7IHmbx+fVtBiQEYhmsWf02QsXVuuoKBE1TFUWENoHRufIzKLPeH+QegcE8kGdMEDN/Jth8MgAftENVY8wbCxfrsEWqC7NGCHDBt+zACtz/l75q1BFWEIf6qigxsmHd1/SesFeWBYbvagYmA7GtU7tiazN7R30/h4nDz3acOZnBxxItYr44VGDEntDT3KkxVipKkh1RE1NefTEgG+yXyQ3yz8d+OAnwK52hi3evB8SZgW1OwZm8+uxlMgRCfJfHHDUN/z9ODlynrl5Vksg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synaptics.com; dmarc=pass action=none header.from=synaptics.com; dkim=pass header.d=synaptics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector2-Synaptics-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bpw4V+QcHiY7OKM83+PXT+nZRYTlHkfnTY6HW4l9taQ=; b=DkRCG5r50CL+Ht/5umrByyx7YAWRO1rNezkloYyxBflTjPm7leDLtitceZozRDlMYnhb43Odq0RV/XCdPnUxoxgOPfbY8iYn+G50nyDOjkpVcFf8nSZzjjBZxK3D3PSwMxjt4sDBp6rZs2JZcalotGfJvWxfE7N3NS/qaoNqIfM= Received: from BYAPR03MB4773.namprd03.prod.outlook.com (20.179.92.152) by BYAPR03MB3463.namprd03.prod.outlook.com (52.135.212.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Tue, 20 Aug 2019 01:51:52 +0000 Received: from BYAPR03MB4773.namprd03.prod.outlook.com ([fe80::a517:3578:67bf:6c88]) by BYAPR03MB4773.namprd03.prod.outlook.com ([fe80::a517:3578:67bf:6c88%7]) with mapi id 15.20.2157.022; Tue, 20 Aug 2019 01:51:52 +0000 From: Jisheng Zhang To: "Naveen N. Rao" CC: Anil S Keshavamurthy , Borislav Petkov , Catalin Marinas , "David S. Miller" , "H. Peter Anvin" , Masami Hiramatsu , Ingo Molnar , Steven Rostedt , Thomas Gleixner , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH 1/4] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE Thread-Topic: [PATCH 1/4] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE Thread-Index: AQHVVoJFk8X59Zi3AUirAcI9pTWKbqcCrVAAgACWOIA= Date: Tue, 20 Aug 2019 01:51:52 +0000 Message-ID: <20190820094041.7072d90b@xhacker.debian> References: <20190819192422.5ed79702@xhacker.debian> <20190819192505.483c0bf0@xhacker.debian> <1566232801.derqq08wxh.naveen@linux.ibm.com> In-Reply-To: <1566232801.derqq08wxh.naveen@linux.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [124.74.246.114] x-clientproxiedby: TY2PR01CA0059.jpnprd01.prod.outlook.com (2603:1096:404:10a::23) To BYAPR03MB4773.namprd03.prod.outlook.com (2603:10b6:a03:134::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbe1173c-2227-4a0e-9397-08d72510f8ea x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BYAPR03MB3463; x-ms-traffictypediagnostic: BYAPR03MB3463: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 013568035E x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(366004)(39850400004)(136003)(346002)(376002)(199004)(189003)(43544003)(2906002)(86362001)(476003)(256004)(14444005)(6506007)(386003)(66476007)(66556008)(64756008)(66446008)(66946007)(5024004)(486006)(6436002)(9686003)(6512007)(5660300002)(53936002)(6246003)(446003)(26005)(11346002)(102836004)(186003)(7736002)(50226002)(1076003)(66066001)(6916009)(71200400001)(99286004)(81156014)(14454004)(81166006)(8936002)(305945005)(8676002)(6116002)(3846002)(7416002)(478600001)(4326008)(25786009)(229853002)(316002)(71190400001)(6486002)(76176011)(54906003)(52116002)(39210200001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR03MB3463;H:BYAPR03MB4773.namprd03.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:0;MX:1; received-spf: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3NHRwGzMrfDae1rGvWCCGz3UtVq04qqP0eF7NUNqWKCw25kugyxzJVavmEv8R8+RSon2cv8QrRB9V6n+wGs6wjH2k79R94D1c0baeolWMl8y5tzwSpfDkG57l/cwcnINPrledOmwlIUL4zSbKStDP137OBW3QAoC3Phl3G/X2gPKWQhWij1J3x3CL2/WLZFy/tbmgPp+0Hr9MyWA5+9YlSQp5JgKi1UdPYbtsJ1cokoH/o83pHp3lpEMVnBMTdb7PH2Sii0QrelwZ1XJcAQQcWnFeL0oD6bMIPNFv3+zltIakNAKRm7d5yAlmuvRhxLGWpIL6DaX+Jhyh46J8oKi1dGjO+DSuiwDgtjYDx+G/MFVaY1wDuJURQWU0yAPW/PTGFLi2CFt+Z1o46tiEcpz+3MVg1GLMaCHd7+V9/mM+ig= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbe1173c-2227-4a0e-9397-08d72510f8ea X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2019 01:51:52.4470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ryGGrf5vJoBX2+T14QlbD6gaGoogsIfqlnGXoxPB2Fpj7zVA4JAXoJ+PpnjLGISvwsZKSOM6219izaDy7Q4kIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3463 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Aug 2019 22:13:02 +0530 "Naveen N. Rao" wrote: > CAUTION: Email originated externally, do not click links or open attachme= nts unless you recognize the sender and know the content is safe. >=20 >=20 > Jisheng Zhang wrote: > > For KPROBES_ON_FTRACE case, we need to adjust the kprobe's addr > > correspondingly. > > > > Signed-off-by: Jisheng Zhang > > --- > > kernel/kprobes.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > > index 9873fc627d61..f8400753a8a9 100644 > > --- a/kernel/kprobes.c > > +++ b/kernel/kprobes.c > > @@ -1560,6 +1560,9 @@ int register_kprobe(struct kprobe *p) > > addr =3D kprobe_addr(p); > > if (IS_ERR(addr)) > > return PTR_ERR(addr); > > +#ifdef CONFIG_KPROBES_ON_FTRACE > > + addr =3D (kprobe_opcode_t *)ftrace_call_adjust((unsigned long)add= r); > > +#endif > > p->addr =3D addr; =20 >=20 > I'm not sure what this is achieving, but looks wrong to me. Indeed, I didn't take care of non-ftrace addr when KPROBES_ON_FTRACE, will update in next version. thanks >=20 > If you intend to have kprobes default to using ftrace entry for probing > functions, consider over-riding kprobe_lookup_name() -- see powerpc > variant for example. >=20 >=20 > - Naveen >=20