From: Peter Zijlstra <peterz@infradead.org>
To: Kyle Meyer <meyerk@hpe.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Russ Anderson <russ.anderson@hpe.com>,
Kyle Meyer <kyle.meyer@hpe.com>
Subject: Re: [PATCH v3 0/6] perf: Replace MAX_NR_CPUS with dynamic alternatives
Date: Tue, 20 Aug 2019 12:01:54 +0200 [thread overview]
Message-ID: <20190820100154.GJ2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190819202241.87799-1-meyerk@stormcage.eag.rdlabs.hpecorp.net>
On Mon, Aug 19, 2019 at 03:22:41PM -0500, Kyle Meyer wrote:
> The purpose of this patch series is to replace MAX_NR_CPUS with a dynamic value
> throughout perf wherever possible using nr_cpus_online, the number of CPUs
> online during a record session, and cpu__max_cpu, the possible number of CPUs as
> defined in the sysfs. MAX_NR_CPUS is still used by DECLARE_BITMAP at compile
> time, however, it's replaced elsewhere.
>
> This patch series was tested using "perf record -a -g" on both an eight socket
> (288 CPU) system and a single socket (36 CPU) system. Each system was then
> rebooted single socket and eight socket before "perf report" was used to read
> the perf.data out file. "perf report --header" was used to confirm that each
> perf.data file had information on the correct number of CPUs.
>
> Change since v1:
> Broke PATCH 2/2 into multiple patches.
>
> Changes since v2:
> Replaced env->sibling_cores and env->sibling threads with a local pointer and
> refreshed perf/util/svghelper.
>
> Kyle Meyer (6):
> perf: Refactor svg_build_topology_map
> perf/util/svghelper: Replace MAX_NR_CPUS with env->nr_cpus_online
> perf/util/stat: Replace MAX_NR_CPUS with cpu__max_cpu
> perf/util/session: Replace MAX_NR_CPUS with nr_cpus_online
> perf/util/machine: Replace MAX_NR_CPUS with nr_cpus_online
> perf/util/header: Replace MAX_NR_CPUS with cpu__max_cpu
Your series isn't threaed; please play with your git-sendmail (or
whatever other tool you use) arguments.
prev parent reply other threads:[~2019-08-20 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 20:22 [PATCH v3 0/6] perf: Replace MAX_NR_CPUS with dynamic alternatives Kyle Meyer
2019-08-20 10:01 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820100154.GJ2332@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kyle.meyer@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meyerk@hpe.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=russ.anderson@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).