From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD91C3A589 for ; Tue, 20 Aug 2019 13:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38C3522CF7 for ; Tue, 20 Aug 2019 13:56:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gHpXzBj2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730196AbfHTN4X (ORCPT ); Tue, 20 Aug 2019 09:56:23 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43088 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730179AbfHTN4W (ORCPT ); Tue, 20 Aug 2019 09:56:22 -0400 Received: by mail-wr1-f68.google.com with SMTP id y8so12500557wrn.10 for ; Tue, 20 Aug 2019 06:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wDIyrvQrJ7olDJx41Fmi3P0la+SkzTZEmDdMNDh+30I=; b=gHpXzBj2HL/VekC+rb66mdgaCBKRClLKy21GikAy3/4y5NYI7osptw1VTKx7dbKmgm wTBMtuCGm6J3JkWDmtHxAjvJ7+An0qz0fmggqwT9d75Qt4eKVYsf+UZhGRDxXymwKaRl CgZPfsylKsFcoYik07XFEyQMFuZZlRWgVFhduIAoOAWgXMt4Jw41KIF6HD1vdy8kPdXB A65WjUhS70ecM65suXwwNrL2owGD4dozg0DmiHFH79YckQU9hhBJL4/kgV5YmxnDBdLI SMqg926sVYcMMFdKRJC6uN4odrvDKlRR6Kw5kZoypu/h2BlONSYPV1qtI7nEbBUf2aaw 0Duw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wDIyrvQrJ7olDJx41Fmi3P0la+SkzTZEmDdMNDh+30I=; b=edpCIDjA9PvCx0bzzEgmC9vKolQ+yD/jlL2Z5YTYrrwBFE9S2+r4kbKJPfbUc7qsFu B3R82c4qXjseeWkb/xFWjEKadrIT/j3AyiZfnY2i8QRinqZO0I8moiZu4YQ/RsA8om1a /H17Nhtm6A7LRVodDW2fo3cqu269x8Y8Y2lyb52Iplm+eIcbRY5uhaCDiwiYJPi0Ugir 2fgFZD9DzXgCAkrZwEyeUl0cieEUuabO/vEuNdoraVrpaqf2p87lx2q9mYf/7IFsPzrH qEPnuV7bBh2fyTRiU2x7SsvCHv8hgYAwlu/yPpZ5I/zuMua2Hi2d6vniR9aJm6UGowbJ mVpw== X-Gm-Message-State: APjAAAWCZsGYJoaxXUZEND18bYGphyfrDyLLP01ozmbmYVO4Z5fCN3B4 h2V1gzWUC22I19HDxEJgJ+yydQ== X-Google-Smtp-Source: APXvYqzz1/Yz1/10NYh2GUB6nM4DQfiK8JY8XxzUwqSv7W5p2geXhM3XKJZmh4+lXcZIK+QpcDCQww== X-Received: by 2002:adf:fdcc:: with SMTP id i12mr35734925wrs.88.1566309380044; Tue, 20 Aug 2019 06:56:20 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id a11sm18644102wrx.59.2019.08.20.06.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 06:56:19 -0700 (PDT) Date: Tue, 20 Aug 2019 14:56:17 +0100 From: Daniel Thompson To: Matthias Kaehlcke Cc: Thierry Reding , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Enric Balletbo i Serra , Douglas Anderson , Brian Norris , Pavel Machek , Jacek Anaszewski Subject: Re: [PATCH v3 2/4] backlight: Expose brightness curve type through sysfs Message-ID: <20190820135617.64urowbu2kwdynib@holly.lan> References: <20190709190007.91260-1-mka@chromium.org> <20190709190007.91260-3-mka@chromium.org> <20190807201528.GO250418@google.com> <510f6d8a-71a0-fa6e-33ea-c4a4bfa96607@linaro.org> <20190816175317.GU250418@google.com> <20190819100241.5pctjxmsq6crlale@holly.lan> <20190819185049.GZ250418@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819185049.GZ250418@google.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 11:50:49AM -0700, Matthias Kaehlcke wrote: > Hi Daniel, > > On Mon, Aug 19, 2019 at 11:02:41AM +0100, Daniel Thompson wrote: > > On Fri, Aug 16, 2019 at 10:53:17AM -0700, Matthias Kaehlcke wrote: > > > On Fri, Aug 16, 2019 at 04:54:18PM +0100, Daniel Thompson wrote: > > > > On 07/08/2019 21:15, Matthias Kaehlcke wrote: > > > > > On Tue, Jul 09, 2019 at 12:00:05PM -0700, Matthias Kaehlcke wrote: > > > > > > Backlight brightness curves can have different shapes. The two main > > > > > > types are linear and non-linear curves. The human eye doesn't > > > > > > perceive linearly increasing/decreasing brightness as linear (see > > > > > > also 88ba95bedb79 "backlight: pwm_bl: Compute brightness of LED > > > > > > linearly to human eye"), hence many backlights use non-linear (often > > > > > > logarithmic) brightness curves. The type of curve currently is opaque > > > > > > to userspace, so userspace often uses more or less reliable heuristics > > > > > > (like the number of brightness levels) to decide whether to treat a > > > > > > backlight device as linear or non-linear. > > > > > > > > > > > > Export the type of the brightness curve via the new sysfs attribute > > > > > > 'scale'. The value of the attribute can be 'linear', 'non-linear' or > > > > > > 'unknown'. For devices that don't provide information about the scale > > > > > > of their brightness curve the value of the 'scale' attribute is 'unknown'. > > > > > > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > > > > > > > Daniel (et al): do you have any more comments on this patch/series or > > > > > is it ready to land? > > > > > > > > I decided to leave it for a long while for others to review since I'm still > > > > a tiny bit uneasy about the linear/non-linear terminology. > > > > > > > > However that's my only concern, its fairly minor and I've dragged by feet > > > > for more then long enough, so: > > > > Reviewed-by: Daniel Thompson > > > > > > Thanks! > > > > > > If you or someone else has another suggestion for the terminology that > > > we can all agree on I'm happy to change it. > > > > As you will see in my reply to Uwe. The term I tend to adopt when I want > > to be precise about userspace behaviour is "perceptual" (e.g. that a > > backlight can be mapped directly to a slider and it will feel right). > > > > However that raises its own concerns: mostly about what is perceptual > > enough. > > > > Clear the automatic brightness curve support in the PWM driver is > > perceptual. > > > > To be honest I suspect that in most cases a true logarithmic curve (given a > > sane exponent) would be perceptual enough. In other words it will feel > > comfortable with a direct mapped slider and using it for animation > > won't be too bad. > > > > However when we get right down to it *that* is the information that is > > actually most useful to userspace: explicit confirmation that the scale > > can be mapped directly to a slider. I think it also aligned better with > > Uwe's feedback (e.g. to start working towards having a preferred scale). > > IIUC the conclusion is that there is no need for a string attribute > because we only need to distinguish between 'perceptual' and > 'non-perceptual'. If that is correct, do you have any preference for > the attribute name ('perceptual_scale', 'perceptual', ...)? More a summary than a conclusion! There is a reason I have left a bit or space for others to comment on this over the last month (and a bit). To be clear my Reviewed-by: means that I believe that the kernel is better with "non-linear/linear/unknown" than without it and that I am comfortable the API isn't likely to be a millstone for us. Lee, Jingoo: Either of you care to offer $0.02 Daniel.