From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
tglx@linutronix.de
Subject: Re: [PATCH] sched/core: Schedule new worker even if PI-blocked
Date: Tue, 20 Aug 2019 16:59:26 +0200 [thread overview]
Message-ID: <20190820145926.jhnpwiicv73z6ol3@linutronix.de> (raw)
In-Reply-To: <20190820135014.GQ2332@hirez.programming.kicks-ass.net>
On 2019-08-20 15:50:14 [+0200], Peter Zijlstra wrote:
> On Fri, Aug 16, 2019 at 06:06:26PM +0200, Sebastian Andrzej Siewior wrote:
> > If a task is PI-blocked (blocking on sleeping spinlock) then we don't want to
> > schedule a new kworker if we schedule out due to lock contention because !RT
> > does not do that as well.
>
> s/as well/either/
>
> > A spinning spinlock disables preemption and a worker
> > does not schedule out on lock contention (but spin).
>
> I'm not much liking this; it means that rt_mutex and mutex have
> different behaviour, and there are 'normal' rt_mutex users in the tree.
There isc RCU (boosting) and futex. I'm sceptical about the i2c users…
> > On RT the RW-semaphore implementation uses an rtmutex so
> > tsk_is_pi_blocked() will return true if a task blocks on it. In this case we
> > will now start a new worker
>
> I'm confused, by bailing out early it does _NOT_ start a new worker; or
> am I reading it wrong?
s@now@not@. Your eyes work good, soory for that.
> > which may deadlock if one worker is waiting on
> > progress from another worker.
>
> > Since a RW-semaphore starts a new worker on !RT, we should do the same on RT.
> >
> > XFS is able to trigger this deadlock.
> >
> > Allow to schedule new worker if the current worker is PI-blocked.
>
> Which contradicts earlier parts of this changelog.
>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > kernel/sched/core.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3945,7 +3945,7 @@ void __noreturn do_task_dead(void)
> >
> > static inline void sched_submit_work(struct task_struct *tsk)
> > {
> > - if (!tsk->state || tsk_is_pi_blocked(tsk))
> > + if (!tsk->state)
> > return;
> >
> > /*
> > @@ -3961,6 +3961,9 @@ static inline void sched_submit_work(str
> > preempt_enable_no_resched();
> > }
> >
> > + if (tsk_is_pi_blocked(tsk))
> > + return;
> > +
> > /*
> > * If we are going to sleep and we have plugged IO queued,
> > * make sure to submit it to avoid deadlocks.
>
> What do we need that clause for? Why is pi_blocked special _at_all_?
so !RT the scheduler does nothing special if a task blocks on sleeping
lock.
If I remember correctly then blk_schedule_flush_plug() is the problem.
It may require a lock which is held by the task.
It may hold A and wait for B while another task has B and waits for A.
If my memory does bot betray me then ext+jbd can lockup without this.
Sebastian
next prev parent reply other threads:[~2019-08-20 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 16:06 [PATCH] sched/core: Schedule new worker even if PI-blocked Sebastian Andrzej Siewior
2019-08-19 9:52 ` [tip:sched/urgent] " tip-bot for Sebastian Andrzej Siewior
2019-08-20 13:50 ` [PATCH] " Peter Zijlstra
2019-08-20 14:59 ` Sebastian Andrzej Siewior [this message]
2019-08-20 15:20 ` Peter Zijlstra
2019-08-20 15:54 ` Sebastian Andrzej Siewior
2019-08-20 16:02 ` Peter Zijlstra
2019-08-20 16:14 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820145926.jhnpwiicv73z6ol3@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).