From: Bharath Vedartham <linux.bhar@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Dimitri Sivanich <sivanich@hpe.com>,
Andrew Morton <akpm@linux-foundation.org>,
jglisse@redhat.com, ira.weiny@intel.com,
gregkh@linuxfoundation.org, arnd@arndb.de,
william.kucharski@oracle.com, hch@lst.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*()
Date: Tue, 20 Aug 2019 21:54:32 +0530 [thread overview]
Message-ID: <20190820162432.GB5153@bharath12345-Inspiron-5559> (raw)
In-Reply-To: <0c2ad29b-934c-ec30-66c3-b153baf1fba5@nvidia.com>
On Mon, Aug 19, 2019 at 12:30:18PM -0700, John Hubbard wrote:
> On 8/19/19 12:06 PM, Bharath Vedartham wrote:
> >On Mon, Aug 19, 2019 at 07:56:11AM -0500, Dimitri Sivanich wrote:
> >>Reviewed-by: Dimitri Sivanich <sivanich@hpe.com>
> >Thanks!
> >
> >John, would you like to take this patch into your miscellaneous
> >conversions patch set?
> >
>
> (+Andrew and Michal, so they know where all this is going.)
>
> Sure, although that conversion series [1] is on a brief hold, because
> there are additional conversions desired, and the API is still under
> discussion. Also, reading between the lines of Michal's response [2]
> about it, I think people would prefer that the next revision include
> the following, for each conversion site:
>
> Conversion of gup/put_page sites:
>
> Before:
>
> get_user_pages(...);
> ...
> for each page:
> put_page();
>
> After:
>
> gup_flags |= FOLL_PIN; (maybe FOLL_LONGTERM in some cases)
> vaddr_pin_user_pages(...gup_flags...)
> ...
> vaddr_unpin_user_pages(); /* which invokes put_user_page() */
>
> Fortunately, it's not harmful for the simpler conversion from put_page()
> to put_user_page() to happen first, and in fact those have usually led
> to simplifications, paving the way to make it easier to call
> vaddr_unpin_user_pages(), once it's ready. (And showing exactly what
> to convert, too.)
>
> So for now, I'm going to just build on top of Ira's tree, and once the
> vaddr*() API settles down, I'll send out an updated series that attempts
> to include the reviews and ACKs so far (I'll have to review them, but
> make a note that review or ACK was done for part of the conversion),
> and adds the additional gup(FOLL_PIN), and uses vaddr*() wrappers instead of
> gup/pup.
>
> [1] https://lore.kernel.org/r/20190807013340.9706-1-jhubbard@nvidia.com
>
> [2] https://lore.kernel.org/r/20190809175210.GR18351@dhcp22.suse.cz
>
Cc' lkml(I missed out the 'l' in this series).
sounds good. It makes sense to keep the entire gup in the kernel rather
than to expose it outside.
I ll make sure to checkout the emails on vaddr*() API and pace my work
on it accordingly.
Thank you
Bharath
> thanks,
> --
> John Hubbard
> NVIDIA
next prev parent reply other threads:[~2019-08-20 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1566157135-9423-1-git-send-email-linux.bhar@gmail.com>
2019-08-18 19:38 ` [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page() to put_user_page*() Bharath Vedartham
2019-08-18 19:51 ` Bharath Vedartham
2019-08-19 12:56 ` Dimitri Sivanich
2019-08-19 12:56 ` Dimitri Sivanich
2019-08-19 19:06 ` Bharath Vedartham
2019-08-19 19:30 ` John Hubbard
2019-08-20 8:18 ` Michal Hocko
2019-08-20 20:50 ` John Hubbard
2019-08-20 16:24 ` Bharath Vedartham [this message]
2019-08-18 19:38 ` [Linux-kernel-mentees][PATCH 2/2] sgi-gru: Remove uneccessary ifdef for CONFIG_HUGETLB_PAGE Bharath Vedartham
2019-08-18 19:51 ` Bharath Vedartham
2019-08-19 13:00 ` Dimitri Sivanich
2019-08-19 19:07 ` Bharath Vedartham
2019-08-18 19:50 ` [Linux-kernel-mentees][PATCH v6 0/2] get_user_pages changes Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820162432.GB5153@bharath12345-Inspiron-5559 \
--to=linux.bhar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=sivanich@hpe.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).