From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE62DC3A589 for ; Tue, 20 Aug 2019 18:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B502222CF7 for ; Tue, 20 Aug 2019 18:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ETn6ov6v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730665AbfHTSY6 (ORCPT ); Tue, 20 Aug 2019 14:24:58 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34354 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730535AbfHTSY6 (ORCPT ); Tue, 20 Aug 2019 14:24:58 -0400 Received: by mail-pf1-f196.google.com with SMTP id b24so3887138pfp.1 for ; Tue, 20 Aug 2019 11:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=54TsZDfDW3TriN1nqx27Ow/a4BBsLJIgLp0TtrQghOk=; b=ETn6ov6vEQVZ6Z8d+QOJIR5ZdOHT4ZDivDB2VkpQ0qnDIs9MQrQ638udwnr/9nsV39 Q9CE1bjJjQqBou8vTO6RAPzU8X9Tiq1MLFyQK2/DJWm5diN99WuwayJaLt2azZswGQO6 PgJRFVxL4YQGtCWP5gy6mT//u52PocvwVbmI1tMnbwHSew1qhj9G4kLkgm0cfOXOG/+z KBuOacguM7Ku15bvGQe9U+2RVhwBdPlfoBEveO5qY2aaNvMSGTBP0IPNRwdL5M9uwBLI rRbk5djqLbCbCvoJbmUcAx9Gb5ONtUGkfOKYOiRtBndtwfw3IyR9R3OQOevfv1X/iVGx ii2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=54TsZDfDW3TriN1nqx27Ow/a4BBsLJIgLp0TtrQghOk=; b=CAveTnLoCG/NliSxJqW50pYm/WHZFDMGuKSQb7SD4YnwAPLmswLtGOcPz/7HxGluhE uEsqTuO5q9P+vTN3xi99r0rMZxFDP60QQh+2lZVh9yyjKUcYWbXC0FjXC/rF0Y+4J3dv RWKq1ooIeSVwlZzOo5GVcUuJ9M7myH7yIjym4d1JkfSb3Gwh4t2wNhzn+i1cHJpc+BL0 xTL05Bh2LAfiE0vMtMZIrdNMJXy3d7fnQJccjEJOLIZolWBP8BrFlU9Y9AYEjq+6rYTJ jUvrzTkd7btPwXxdTg3FWgpiUhspcig1F4Hv4IcB3ickEozOwoXsoRKuNKtA4TaOEtPh eQlw== X-Gm-Message-State: APjAAAWU2PUSqe1jpZDIXxXV/KFJhABW4AZhtSFFvBE0+e+j+DwRtb++ LWsa7SI1dPQme9M3ys8Em7U5Kw== X-Google-Smtp-Source: APXvYqz6e4UEkK1ofDpL52W0zxkSIj5ZMAzgsILYeZML13HEn/+04ibT+w1ZAtBgHDGP+VY3TZZ4jA== X-Received: by 2002:a17:90a:3aaf:: with SMTP id b44mr1312628pjc.87.1566325496873; Tue, 20 Aug 2019 11:24:56 -0700 (PDT) Received: from google.com ([2620:15c:2cb:1:e90c:8e54:c2b4:29e7]) by smtp.gmail.com with ESMTPSA id u16sm20305376pgm.83.2019.08.20.11.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 11:24:55 -0700 (PDT) Date: Tue, 20 Aug 2019 11:24:50 -0700 From: Brendan Higgins To: shuah Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, sboyd@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, Bjorn Helgaas Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190820182450.GA38078@google.com> References: <20190814055108.214253-1-brendanhiggins@google.com> <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 20, 2019 at 11:24:45AM -0600, shuah wrote: > On 8/13/19 11:50 PM, Brendan Higgins wrote: > > ## TL;DR > > > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > > changes are pretty minor stuff that doesn't affect the API in anyway. > > One significant change, however, is that I added support for freeing > > kunit_resource managed resources before the test case is finished via > > kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke > > KUnit on certain configurations (like the default one for x86, whoops). > > > > Based on Stephen's feedback on the previous change, I think we are > > pretty close. I am not expecting any significant changes from here on > > out. > > > > Hi Brendan, > > I found checkpatch errors in one or two patches. Can you fix those and > send v14. Hi Shuah, Are you refering to the following errors? ERROR: Macros with complex values should be enclosed in parentheses #144: FILE: include/kunit/test.h:456: +#define KUNIT_BINARY_CLASS \ + kunit_binary_assert, KUNIT_INIT_BINARY_ASSERT_STRUCT ERROR: Macros with complex values should be enclosed in parentheses #146: FILE: include/kunit/test.h:458: +#define KUNIT_BINARY_PTR_CLASS \ + kunit_binary_ptr_assert, KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT These values should *not* be in parentheses. I am guessing checkpatch is getting confused and thinks that these are complex expressions, when they are not. I ignored the errors since I figured checkpatch was complaining erroneously. I could refactor the code to remove these macros entirely, but I think the code is cleaner with them. What would you prefer I do? NB: These macros are introduced in: "[PATCH v13 05/18] kunit: test: add the concept of expectations" Thanks!