linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Thomas Hellström (VMware)" <thomas_os@shipmail.org>
Cc: linux-kernel@vger.kernel.org, pv-drivers@vmware.com,
	Thomas Hellstrom <thellstrom@vmware.com>,
	linux-input@vger.kernel.org, Doug Covelli <dcovelli@vmware.com>
Subject: Re: [PATCH 4/4] input/vmmouse: Update the backdoor call with support for new instructions
Date: Tue, 20 Aug 2019 22:09:25 -0700	[thread overview]
Message-ID: <20190821050925.GA566@penguin> (raw)
In-Reply-To: <20190818143316.4906-5-thomas_os@shipmail.org>

On Sun, Aug 18, 2019 at 04:33:16PM +0200, Thomas Hellström (VMware) wrote:
> From: Thomas Hellstrom <thellstrom@vmware.com>
> 
> Use the definition provided by include/asm/vmware.h
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: <linux-input@vger.kernel.org>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> Reviewed-by: Doug Covelli <dcovelli@vmware.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Please feel free to merge with the rest of the patches introducing
VMWARE_HYPERCALL.

> ---
>  drivers/input/mouse/vmmouse.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c
> index 871e5b5ab129..0c7707c7bede 100644
> --- a/drivers/input/mouse/vmmouse.c
> +++ b/drivers/input/mouse/vmmouse.c
> @@ -16,6 +16,7 @@
>  #include <linux/slab.h>
>  #include <linux/module.h>
>  #include <asm/hypervisor.h>
> +#include <asm/vmware.h>
>  
>  #include "psmouse.h"
>  #include "vmmouse.h"
> @@ -84,7 +85,7 @@ struct vmmouse_data {
>  #define VMMOUSE_CMD(cmd, in1, out1, out2, out3, out4)	\
>  ({							\
>  	unsigned long __dummy1, __dummy2;		\
> -	__asm__ __volatile__ ("inl %%dx" :		\
> +	__asm__ __volatile__ (VMWARE_HYPERCALL :	\
>  		"=a"(out1),				\
>  		"=b"(out2),				\
>  		"=c"(out3),				\
> -- 
> 2.20.1
> 

Thanks.

-- 
Dmitry

  reply	other threads:[~2019-08-21 15:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 14:33 [PATCH 0/4] Add support for updated vmware hypercall instruction Thomas Hellström (VMware)
2019-08-18 14:33 ` [PATCH 1/4] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls Thomas Hellström (VMware)
2019-08-18 19:20   ` Thomas Gleixner
2019-08-18 19:46     ` Thomas Hellström (VMware)
2019-08-20 17:18     ` [Pv-drivers] " Darren Hart
2019-08-18 14:33 ` [PATCH 2/4] x86/vmware: Add a header file for hypercall definitions Thomas Hellström (VMware)
2019-08-18 20:19   ` Borislav Petkov
2019-08-18 20:39     ` Borislav Petkov
2019-08-18 22:28     ` Thomas Hellström (VMware)
2019-08-19  6:25       ` Borislav Petkov
2019-08-19  7:49         ` Thomas Hellström (VMware)
2019-08-20 11:32   ` Peter Zijlstra
2019-08-20 13:34     ` Thomas Hellström (VMware)
2019-08-20 13:42       ` Thomas Gleixner
2019-08-20 19:19         ` Thomas Hellström (VMware)
2019-08-20 19:23           ` Thomas Gleixner
2019-08-18 14:33 ` [PATCH 3/4] drm/vmwgfx: Update the backdoor call with support for new instructions Thomas Hellström (VMware)
2019-08-18 14:33 ` [PATCH 4/4] input/vmmouse: " Thomas Hellström (VMware)
2019-08-21  5:09   ` Dmitry Torokhov [this message]
2019-08-21 15:48     ` Thomas Hellström (VMware)
2019-08-21 16:03       ` Dmitry Torokhov
2019-08-18 18:09 ` [PATCH 0/4] Add support for updated vmware hypercall instruction Borislav Petkov
2019-08-18 19:02   ` Thomas Hellström (VMware)
2019-08-18 19:37     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821050925.GA566@penguin \
    --to=dmitry.torokhov@gmail.com \
    --cc=dcovelli@vmware.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=thellstrom@vmware.com \
    --cc=thomas_os@shipmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).