From: "Tobin C. Harding" <me@tobin.cc>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Joe Perches <joe@perches.com>,
Caitlyn <caitlynannefinn@gmail.com>, Chao Yu <yuchao0@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.
Date: Wed, 21 Aug 2019 08:13:35 -0700 [thread overview]
Message-ID: <20190821151241.GF12461@ares> (raw)
In-Reply-To: <20190821023122.GA159802@architecture4>
On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote:
> On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote:
> > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote:
> > > Balanced braces to fix some checkpath warnings in inode.c and
> > > unzip_vle.c
> > []
> > > diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
> > []
> > > @@ -915,21 +915,21 @@ static int z_erofs_vle_unzip(struct super_block *sb,
> > > mutex_lock(&work->lock);
> > > nr_pages = work->nr_pages;
> > >
> > > - if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES))
> > > + if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES)) {
> > > pages = pages_onstack;
> > > - else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&
> > > - mutex_trylock(&z_pagemap_global_lock))
> > > + } else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES &&
> > > + mutex_trylock(&z_pagemap_global_lock)) {
> >
> > Extra space after tab
>
> There is actually balanced braces in linux-next.
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/erofs/zdata.c#n762
Which tree did these changes go in through please Gao? I believe
Caitlyn was working off of the staging-next branch of Greg's staging
tree.
thanks,
Tobin.
next prev parent reply other threads:[~2019-08-21 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 0:18 [PATCH 0/2] Submitting my first patch series (Checkpatch fixes) Caitlyn
2019-08-21 0:18 ` [PATCH 1/2] staging/erofs/xattr.h: Fixed misaligned function arguments Caitlyn
2019-08-21 2:20 ` Greg Kroah-Hartman
2019-08-21 0:18 ` [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements Caitlyn
2019-08-21 0:40 ` Gao Xiang
2019-08-21 2:26 ` Joe Perches
2019-08-21 2:31 ` Gao Xiang
2019-08-21 15:13 ` Tobin C. Harding [this message]
2019-08-21 15:52 ` Gao Xiang
2019-08-21 20:11 ` Caitlyn Finn
2019-08-21 0:39 ` [PATCH 0/2] Submitting my first patch series (Checkpatch fixes) Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821151241.GF12461@ares \
--to=me@tobin.cc \
--cc=caitlynannefinn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).