From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE6FC3A59E for ; Wed, 21 Aug 2019 17:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7287422CF7 for ; Wed, 21 Aug 2019 17:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566410105; bh=/wrI+TO/Qvvu10E5aQcTPJcHKdINeyDppkiK1mwGkRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yVug8qZh/5Ceq3fV0lPceQDJwWf7AjMUUX/z/lFT9HxLtUGUVRvcNddBIqay4LFRu iq8RgkMkH3aemhcO9wTWPNaY8uPmfYhpIsva768f5z4+/2R9Z4PvbVciF3vqUo0bBg Nsqk2R5CATdx/MJQaIyz0dGgHuyoqrib2f6MT+6Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729610AbfHURzE (ORCPT ); Wed, 21 Aug 2019 13:55:04 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43878 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729508AbfHURzE (ORCPT ); Wed, 21 Aug 2019 13:55:04 -0400 Received: by mail-wr1-f68.google.com with SMTP id y8so2864140wrn.10; Wed, 21 Aug 2019 10:55:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dcXFfpfF7Y1vSw3aVBKIoINByXS6ksD7OwWYj454PWY=; b=C9KV221Eocif3ZekpE++QYsPVzUwSukjZei79hd9cPiO+acWKnIJR3q5PDoG9GwF3D 1a3b08fTOrahtAnpNIMfKzDqG03RtqJeEuHNGp6jr6uVefZp4ymQZfGJcy+rBO+nmiiY OucKl0Jl4nZxgFmU/I2t4VEJIGjVQhQS9vprDl6annqJRWKYqRiurxQuhCtYcNzzyfz0 ePOkODMaJk5U2GXoY2T1Avpj7mjPPOPu91Ue7WDyfkp2LhA1rCMnjg9AKG5WFODN4coW HqZ9FuXYDZ5/vb+j2w4/FOPdpEzm/HJu8Gdh9PvZOe4XY/7lyR+/02/pka0f8KPZkgwQ Cq3g== X-Gm-Message-State: APjAAAV7E8KU/sq3EOz1diAxAuB7Nipe5ceqMpx38OQVYv64MUk4mPpx jNw80Qu2uhRJNuD15hRC0+E= X-Google-Smtp-Source: APXvYqzXpe8lKkcvUAGrZ3oVo70oJ142K2QzLV1sGyFExlTS0Degv28KaJGOvQor2VcwLb4RuY3/2g== X-Received: by 2002:a5d:5183:: with SMTP id k3mr37435361wrv.270.1566410101601; Wed, 21 Aug 2019 10:55:01 -0700 (PDT) Received: from kozik-lap ([194.230.147.11]) by smtp.googlemail.com with ESMTPSA id 39sm72535478wrc.45.2019.08.21.10.55.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Aug 2019 10:55:00 -0700 (PDT) Date: Wed, 21 Aug 2019 19:54:58 +0200 From: Krzysztof Kozlowski To: Rob Herring Cc: Schrempf Frieder , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles Message-ID: <20190821175458.GA25168@kozik-lap> References: <1566315318-30320-1-git-send-email-krzk@kernel.org> <1566315318-30320-3-git-send-email-krzk@kernel.org> <20190820202142.GA15866@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 20, 2019 at 03:27:39PM -0500, Rob Herring wrote: > > I see. If I understand the schema correctly, this should look like: > > Looks correct, but a couple of comments. > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 7294ac36f4c0..eb263d1ccf13 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -161,6 +161,22 @@ properties: > > items: > > - enum: > > - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board > > + - kontron,imx6ul-n6310-som # Kontron N6310 SOM > > Is the SOM ever used alone? If not, then no point in listing this here. SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons. Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere. > > > + - const: fsl,imx6ul > > + > > + - description: Kontron N6310 S Board > > + items: > > + - enum: > > + - kontron,imx6ul-n6310-s > > This could be a 'const' instead. It depends if you think there will > ever be more than one entry. Indeed, I'll make this and entry below for S 43 board const. Best regards, Krzysztof