linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Rahul Tanwar <rahul.tanwar@linux.intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
	"alan@linux.intel.com" <alan@linux.intel.com>,
	"ricardo.neri-calderon@linux.intel.com" 
	<ricardo.neri-calderon@linux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wu, Qiming" <qi-ming.wu@intel.com>,
	"Kim, Cheol Yong" <cheol.yong.kim@intel.com>,
	"Tanwar, Rahul" <rahul.tanwar@intel.com>
Subject: Re: [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name
Date: Wed, 21 Aug 2019 13:18:46 -0700	[thread overview]
Message-ID: <20190821201845.GA29589@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20190820145735.GW2332@hirez.programming.kicks-ass.net>

On Tue, Aug 20, 2019 at 04:57:35PM +0200, Peter Zijlstra wrote:
> On Tue, Aug 20, 2019 at 12:48:05PM +0000, Luck, Tony wrote:
> > 
> > >> +#define INTEL_FAM6_ATOM_AIRMONT_NP    0x75 /* Lightning Mountain */
> > > 
> > > What's _NP ?
> > 
> > Network Processor. But that is too narrow a descriptor. This is going to be used in
> > other areas besides networking. 
> > 
> > I’m contemplating calling it AIRMONT2
> 
> What would describe the special sause that warranted a new SOC? If this
> thing is marketed as 'Network Processor' then I suppose we can actually
> use it, esp. if we're going to see this more, like the MID thing -- that
> lived for a while over multiple uarchs.

The reasons for allocating a new model number are a mystery.
I've seen cases where I thought we'd get a new numnber for sure,
but then just bumped the stepping. I've also seen us allocate a
new number when it didn't look needed (to me, from my OS perspective).

As I mentioned above, there are some folks internally that think
NP == Network Processor is too narrow a pigeonhole for this CPU.

But _NPAOS (Network Processor And Other Stuff) doesn't sound helpful.

> Note that for the big cores we added the NNPI thing, which was for
> Neural Network Processing something.

I'm sure that we will invent all sorts of strings for the "OPTDIFF"
part of the name (many of which will only be used once or twice).

Rationale for "AIRMONT2" is that this is derived from Airmont. So
you'd expect many model specific bits of code to do the same for
this as they did for plain AIRMONT. But in a few corner cases there
will be separate code.

Perhaps I need to update the rubric that I just added to the
head on intel-family.h to say that the MICROARCH element may
be followed by an optional number to differentiate SOCs that
use essentially the same core, but have different model numbers
because of SOC differences outside of the core.

-Tony

  parent reply	other threads:[~2019-08-21 20:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16  8:18 [PATCH v2 0/3] x86/cpu: Add new Airmont CPU model Rahul Tanwar
2019-08-16  8:18 ` [PATCH v2 1/3] x86/cpu: Use constant definitions for CPU type Rahul Tanwar
2019-08-17  8:40   ` [tip:x86/cleanups] x86/cpu: Use constant definitions for CPU models tip-bot for Rahul Tanwar
2019-08-16  8:18 ` [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name Rahul Tanwar
2019-08-20 12:22   ` Peter Zijlstra
2019-08-20 12:48     ` Luck, Tony
2019-08-20 13:22       ` Shevchenko, Andriy
2019-08-20 14:20         ` Luck, Tony
2019-08-20 14:57       ` Peter Zijlstra
2019-08-21  3:21         ` Tanwar, Rahul
2019-08-21  9:39           ` Peter Zijlstra
2019-08-21 20:18         ` Luck, Tony [this message]
2019-08-21 21:27           ` Thomas Gleixner
2019-08-22 10:29           ` Peter Zijlstra
2019-08-22 18:53             ` Luck, Tony
2019-08-22 20:35               ` [PATCH] x86/cpu: Add new Airmont variant to Intel family Luck, Tony
2019-08-23  9:03                 ` Peter Zijlstra
2019-08-23  9:23                   ` Tanwar, Rahul
2019-08-20 13:04     ` [PATCH v2 2/3] x86/cpu: Add new Intel Atom CPU model name Thomas Gleixner
2019-08-16  8:18 ` [PATCH v2 3/3] x86/cpu: Update init data for new Atom CPU model Rahul Tanwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821201845.GA29589@agluck-desk2.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=alan@linux.intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=bp@alien8.de \
    --cc=cheol.yong.kim@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qi-ming.wu@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rahul.tanwar@intel.com \
    --cc=rahul.tanwar@linux.intel.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).