From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Jens Axboe <axboe@fb.com>, Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, Paul Pawlowski <paul@mrarm.io>
Subject: Re: [PATCH v4 4/4] nvme-pci: Support shared tags across queues for Apple 2018 controllers
Date: Thu, 22 Aug 2019 02:29:21 +0200 [thread overview]
Message-ID: <20190822002921.GC10391@lst.de> (raw)
In-Reply-To: <20190807075122.6247-5-benh@kernel.crashing.org>
On Wed, Aug 07, 2019 at 05:51:22PM +1000, Benjamin Herrenschmidt wrote:
> Another issue with the Apple T2 based 2018 controllers seem to be
> that they blow up (and shut the machine down) if there's a tag
> collision between the IO queue and the Admin queue.
>
> My suspicion is that they use our tags for their internal tracking
> and don't mix them with the queue id. They also seem to not like
> when tags go beyond the IO queue depth, ie 128 tags.
>
> This adds a quirk that marks tags 0..31 of the IO queue reserved
What a mess. But given how widely available the macbooks are supporting
them makes sense:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-08-22 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 7:51 [PATCH v4 0/4] nvme-pci: Support for Apple 201+ (T2 chip) Benjamin Herrenschmidt
2019-08-07 7:51 ` [PATCH v4 1/4] nvme-pci: Pass the queue to SQ_SIZE/CQ_SIZE macros Benjamin Herrenschmidt
2019-08-07 7:51 ` [PATCH v4 2/4] nvme-pci: Add support for variable IO SQ element size Benjamin Herrenschmidt
2019-08-22 0:28 ` Christoph Hellwig
2019-08-22 0:31 ` Benjamin Herrenschmidt
2019-08-22 18:02 ` Sagi Grimberg
2019-08-23 0:41 ` Benjamin Herrenschmidt
2019-08-23 2:52 ` Sagi Grimberg
2019-08-23 3:50 ` Benjamin Herrenschmidt
2019-08-07 7:51 ` [PATCH v4 3/4] nvme-pci: Add support for Apple 2018+ models Benjamin Herrenschmidt
2019-08-22 0:28 ` Christoph Hellwig
2019-08-07 7:51 ` [PATCH v4 4/4] nvme-pci: Support shared tags across queues for Apple 2018 controllers Benjamin Herrenschmidt
2019-08-22 0:29 ` Christoph Hellwig [this message]
2019-08-08 23:52 ` [PATCH v4 0/4] nvme-pci: Support for Apple 201+ (T2 chip) Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822002921.GC10391@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=paul@mrarm.io \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).