From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, tony.luck@intel.com, x86@kernel.org,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
alan@linux.intel.com, linux-kernel@vger.kernel.org,
qi-ming.wu@intel.com, cheol.yong.kim@intel.com,
rahul.tanwar@intel.com
Subject: Re: [PATCH v1 1/2] x86/rtc: Add option to skip using RTC
Date: Thu, 22 Aug 2019 12:02:08 +0300 [thread overview]
Message-ID: <20190822090208.GJ30120@smile.fi.intel.com> (raw)
In-Reply-To: <becacc523508b295a52db9f1592e2868e3988e28.1566458029.git.rahul.tanwar@linux.intel.com>
On Thu, Aug 22, 2019 at 03:44:03PM +0800, Rahul Tanwar wrote:
> Use a newly introduced optional "status" property of "motorola,mc146818"
> compatible DT node to determine if RTC is supported. Skip read/write from
> RTC device only when this node is present and status is "disabled". In all
> other cases, proceed as before.
Can't we rather update ->get_wallclock() and ->set_wallclock() based on this?
> Suggested-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
> ---
> arch/x86/kernel/rtc.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
> index 586f718b8e95..f9f760a8e76a 100644
> --- a/arch/x86/kernel/rtc.c
> +++ b/arch/x86/kernel/rtc.c
> @@ -32,6 +32,11 @@ EXPORT_SYMBOL(cmos_lock);
> DEFINE_SPINLOCK(rtc_lock);
> EXPORT_SYMBOL(rtc_lock);
>
> +static const struct of_device_id of_cmos_match[] = {
> + { .compatible = "motorola,mc146818" },
> + {}
> +};
> +
> /*
> * In order to set the CMOS clock precisely, set_rtc_mmss has to be
> * called 500 ms after the second nowtime has started, because when
> @@ -42,9 +47,14 @@ EXPORT_SYMBOL(rtc_lock);
> int mach_set_rtc_mmss(const struct timespec64 *now)
> {
> unsigned long long nowtime = now->tv_sec;
> + struct device_node *node;
> struct rtc_time tm;
> int retval = 0;
>
> + node = of_find_matching_node(NULL, of_cmos_match);
> + if (node && !of_device_is_available(node))
> + return -EINVAL;
> +
> rtc_time64_to_tm(nowtime, &tm);
> if (!rtc_valid_tm(&tm)) {
> retval = mc146818_set_time(&tm);
> @@ -63,8 +73,15 @@ int mach_set_rtc_mmss(const struct timespec64 *now)
> void mach_get_cmos_time(struct timespec64 *now)
> {
> unsigned int status, year, mon, day, hour, min, sec, century = 0;
> + struct device_node *node;
> unsigned long flags;
>
> + node = of_find_matching_node(NULL, of_cmos_match);
> + if (node && !of_device_is_available(node)) {
> + now->tv_sec = now->tv_nsec = 0;
> + return;
> + }
> +
> /*
> * If pm_trace abused the RTC as storage, set the timespec to 0,
> * which tells the caller that this RTC value is unusable.
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-08-22 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 7:44 [PATCH v1 0/2] x86/rtc: Add option to skip using RTC Rahul Tanwar
[not found] ` <cover.1566458029.git.rahul.tanwar@linux.intel.com>
2019-08-22 7:44 ` [PATCH v1 1/2] " Rahul Tanwar
2019-08-22 9:02 ` Andy Shevchenko [this message]
2019-08-22 9:26 ` Tanwar, Rahul
2019-08-22 13:04 ` Andy Shevchenko
2019-08-23 3:37 ` Tanwar, Rahul
2019-08-23 12:56 ` Andy Shevchenko
2019-08-26 9:01 ` Tanwar, Rahul
2019-08-22 7:44 ` [PATCH v1 2/2] dt-bindings: rtc: Add optional status property Rahul Tanwar
2019-08-22 8:56 ` Andy Shevchenko
2019-08-22 9:09 ` Alexandre Belloni
2019-08-22 9:38 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822090208.GJ30120@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=a.zummo@towertech.it \
--cc=alan@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bp@alien8.de \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar@intel.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).