From: Sean Young <sean@mess.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: "Antti Palosaari" <crope@iki.fi>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Brad Love" <brad@nextdimension.cc>,
linux-media <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH v4] media: si2168: Refactor command setup code
Date: Thu, 22 Aug 2019 10:10:02 +0100 [thread overview]
Message-ID: <20190822091002.7v7slkrilwfz3d3c@gofer.mess.org> (raw)
In-Reply-To: <499bea86-f483-f776-4512-510c5df9d78f@free.fr>
On Mon, Aug 19, 2019 at 01:54:53PM +0200, Marc Gonzalez wrote:
> On 15/07/2019 11:50, Marc Gonzalez wrote:
>
> > Use cmd_init() to fill a struct si2168_cmd command.
> >
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > ---
> > Changes from v1:
> > - Use a real function to populate struct si2168_cmd *cmd, and a trivial
> > macro wrapping it (macro because sizeof).
> > Changes from v2:
> > - Fix header mess
> > - Add Jonathan's tag
> > Changes from v3:
> > - Drop Jonathan's tag after rewrite
> > - Completely drop macro, and explicitly provide 'wlen' argument
> > ---
> > drivers/media/dvb-frontends/si2168.c | 152 ++++++++-------------------
> > 1 file changed, 44 insertions(+), 108 deletions(-)
>
> Brad, Sean, Antti,
>
> I believe this patch is good to go. Is anything still wrong with it?
It's been accepted:
https://git.linuxtv.org/media_tree.git/commit/?id=619f6fc390909fce3247c3e07e6882b868b645da
Thanks,
Sean
prev parent reply other threads:[~2019-08-22 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:50 [PATCH v4] media: si2168: Refactor command setup code Marc Gonzalez
2019-08-19 11:54 ` Marc Gonzalez
2019-08-22 9:10 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822091002.7v7slkrilwfz3d3c@gofer.mess.org \
--to=sean@mess.org \
--cc=brad@nextdimension.cc \
--cc=crope@iki.fi \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).