From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC509C3A59D for ; Thu, 22 Aug 2019 09:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1DE6233A0 for ; Thu, 22 Aug 2019 09:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="SGase5XA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733221AbfHVJ3J (ORCPT ); Thu, 22 Aug 2019 05:29:09 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36888 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732231AbfHVJ3G (ORCPT ); Thu, 22 Aug 2019 05:29:06 -0400 Received: by mail-wr1-f66.google.com with SMTP id z11so4726327wrt.4 for ; Thu, 22 Aug 2019 02:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zvZLQm2eReId0SwTyMH9VzRmlkdF2ZdYygKx0uvmAk0=; b=SGase5XAZFg+vTPEPlwvJlx1ym/QLLzp1ud2bXoCHajj5R7wkWDyAY3NQMyW+Fa8yk 5TCCIETKfD2hpQpyh+tifopk6nxKPmvbjcRFK1Q7HOAQ+XMIoCYUknmm3EkeolqTHsYm XAE3JtkBJqI9/xyF2u/s0xTJHog+xjFhwlQXOcq63WrxnWnwQa4o79tGYuP2qbab4mpY MubhtDyP2NTE032vF1BczpQQZSJyrKtJMU1BNyw6BjHvG5FaU42RbjCvzhaH9EzhrSHk wkT+7neXomFGGvJMp9BtLhrT5LxpJ/FZKToD9fFKKkk3H9rvhMw06d5uDNaJUDrRpjEF 7gUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zvZLQm2eReId0SwTyMH9VzRmlkdF2ZdYygKx0uvmAk0=; b=lRyEEJw3A5/27Pl1HOSJZUQv93qWlHO71AlF0ssFgrwQA1NzJbSSlsl/F4WdpIl5wZ qy4i/K9MM9IaQFrYLzPw0pfyykwdOJpYjDXA/opc+bVIG1f4KrAbkcjQMwOPTxoO4fPt CKmCOauIQX1u7e2aWX8Wxa8BjGHquL8ju9cxmVBAuGqDhwTliLPe50l/kRMjEvXjmzhm Hi+fhDeCRfwm/Vksm+MoAbpRP+l0sYpTIuEfcIOKXVrYmLFcfyxuFEU2Oyaa9J0Vfb8Q o/k0Xwmw1OqbKRjsBlSd5QibC3gLIk+Hxwf3lvACvgLZGtXM+5lRgmxi9NFEapxJBePR PW+Q== X-Gm-Message-State: APjAAAW+q46b+OD4cX7mNCnw8663P1yl+DKBO9Dtv5W3sFtiGl2oaCeU vLjZmZoM8MUXHrl00FvnNN6yKw== X-Google-Smtp-Source: APXvYqy3MiZfh5jTT4YN2SGl9rGBNzJSpnL2EizF5M0c7ozx13iyKmQrwYFgp8g2hjvLpKPNCjxyIA== X-Received: by 2002:adf:f641:: with SMTP id x1mr7145810wrp.179.1566466145132; Thu, 22 Aug 2019 02:29:05 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id t19sm4383224wmi.29.2019.08.22.02.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 02:29:04 -0700 (PDT) Date: Thu, 22 Aug 2019 11:29:03 +0200 From: Jiri Pirko To: Parav Pandit Cc: Alex Williamson , Jiri Pirko , "David S . Miller" , Kirti Wankhede , Cornelia Huck , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , cjia , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core Message-ID: <20190822092903.GA2276@nanopsycho.orion> References: <20190820111904.75515f58@x1.home> <20190820222051.7aeafb69@x1.home> <20190820225722.237a57d2@x1.home> <20190820232622.164962d3@x1.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Aug 21, 2019 at 08:23:17AM CEST, parav@mellanox.com wrote: > > >> -----Original Message----- >> From: Alex Williamson >> Sent: Wednesday, August 21, 2019 10:56 AM >> To: Parav Pandit >> Cc: Jiri Pirko ; David S . Miller ; >> Kirti Wankhede ; Cornelia Huck >> ; kvm@vger.kernel.org; linux-kernel@vger.kernel.org; >> cjia ; netdev@vger.kernel.org >> Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core >> >> > > > > Just an example of the alias, not proposing how it's set. In >> > > > > fact, proposing that the user does not set it, mdev-core >> > > > > provides one >> > > automatically. >> > > > > >> > > > > > > Since there seems to be some prefix overhead, as I ask about >> > > > > > > above in how many characters we actually have to work with >> > > > > > > in IFNAMESZ, maybe we start with 8 characters (matching your >> > > > > > > "index" namespace) and expand as necessary for disambiguation. >> > > > > > > If we can eliminate overhead in IFNAMESZ, let's start with 12. >> > > > > > > Thanks, >> > > > > > > >> > > > > > If user is going to choose the alias, why does it have to be limited to >> sha1? >> > > > > > Or you just told it as an example? >> > > > > > >> > > > > > It can be an alpha-numeric string. >> > > > > >> > > > > No, I'm proposing a different solution where mdev-core creates >> > > > > an alias based on an abbreviated sha1. The user does not provide the >> alias. >> > > > > >> > > > > > Instead of mdev imposing number of characters on the alias, it >> > > > > > should be best >> > > > > left to the user. >> > > > > > Because in future if netdev improves on the naming scheme, >> > > > > > mdev will be >> > > > > limiting it, which is not right. >> > > > > > So not restricting alias size seems right to me. >> > > > > > User configuring mdev for networking devices in a given kernel >> > > > > > knows what >> > > > > user is doing. >> > > > > > So user can choose alias name size as it finds suitable. >> > > > > >> > > > > That's not what I'm proposing, please read again. Thanks, >> > > > >> > > > I understood your point. But mdev doesn't know how user is going >> > > > to use >> > > udev/systemd to name the netdev. >> > > > So even if mdev chose to pick 12 characters, it could result in collision. >> > > > Hence the proposal to provide the alias by the user, as user know >> > > > the best >> > > policy for its use case in the environment its using. >> > > > So 12 character sha1 method will still work by user. >> > > >> > > Haven't you already provided examples where certain drivers or >> > > subsystems have unique netdev prefixes? If mdev provides a unique >> > > alias within the subsystem, couldn't we simply define a netdev >> > > prefix for the mdev subsystem and avoid all other collisions? I'm >> > > not in favor of the user providing both a uuid and an >> > > alias/instance. Thanks, >> > > >> > For a given prefix, say ens2f0, can two UUID->sha1 first 9 characters have >> collision? >> >> I think it would be a mistake to waste so many chars on a prefix, but 9 >> characters of sha1 likely wouldn't have a collision before we have 10s of >> thousands of devices. Thanks, >> >> Alex > >Jiri, Dave, >Are you ok with it for devlink/netdev part? >Mdev core will create an alias from a UUID. > >This will be supplied during devlink port attr set such as, > >devlink_port_attrs_mdev_set(struct devlink_port *port, const char *mdev_alias); > >This alias is used to generate representor netdev's phys_port_name. >This alias from the mdev device's sysfs will be used by the udev/systemd to generate predicable netdev's name. >Example: enm What happens in unlikely case of 2 UUIDs collide? >I took Ethernet mdev as an example. >New prefix 'm' stands for mediated device. >Remaining 12 characters are first 12 chars of the mdev alias. Does this resolve the identification of devlink port representor? I assume you want to use the same 12(or so) chars, don't you?