From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B15DC3A5A1 for ; Thu, 22 Aug 2019 17:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F68020856 for ; Thu, 22 Aug 2019 17:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495392; bh=rc15NeYvlXykM6VbKkqFX1suUXQMOYBp3/zAI8e9sJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jcSwSfokJWay1RE8GXuNr4fTyKMzFFnGtQ81m8WxB01mycj88Xt1Mg41CXTfYjUgY B18s11rDXpQ4inydBV8G0T6X6E1yoon6E3BqlPSRSXda6a6KRMwV9DemnKuxZWIeBU YmtMqEsg6ixoPyw//19E4bSSu3qTZOQLL3279jp8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391574AbfHVRgb (ORCPT ); Thu, 22 Aug 2019 13:36:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391584AbfHVRYu (ORCPT ); Thu, 22 Aug 2019 13:24:50 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 164EE23407; Thu, 22 Aug 2019 17:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494690; bh=rc15NeYvlXykM6VbKkqFX1suUXQMOYBp3/zAI8e9sJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T6WvYc014RKxEG2bI9VRxhVig4VOsBJxIWb2SQPxXo6GuQsHJI+k8G/X8pyLwpPCW WrUOCu6A/v/JHyW0xbSQ4NZi+Q+5Kez2USfJ0KwMxhLbFg6Ut1lSJpjs7Xh+YsFhTc meLQ5kNf9wvKixTQ0+mlX0eSZ7uG1+R/KWjYxMTM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Luck , Doug Ledford , Sasha Levin Subject: [PATCH 4.14 37/71] IB/core: Add mitigation for Spectre V1 Date: Thu, 22 Aug 2019 10:19:12 -0700 Message-Id: <20190822171729.519810766@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171726.131957995@linuxfoundation.org> References: <20190822171726.131957995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 61f259821dd3306e49b7d42a3f90fb5a4ff3351b ] Some processors may mispredict an array bounds check and speculatively access memory that they should not. With a user supplied array index we like to play things safe by masking the value with the array size before it is used as an index. Signed-off-by: Tony Luck Link: https://lore.kernel.org/r/20190731043957.GA1600@agluck-desk2.amr.corp.intel.com Signed-off-by: Doug Ledford Signed-off-by: Sasha Levin --- drivers/infiniband/core/user_mad.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c index 6511cb21f6e20..4a137bf584b04 100644 --- a/drivers/infiniband/core/user_mad.c +++ b/drivers/infiniband/core/user_mad.c @@ -49,6 +49,7 @@ #include #include #include +#include #include @@ -856,11 +857,14 @@ static int ib_umad_unreg_agent(struct ib_umad_file *file, u32 __user *arg) if (get_user(id, arg)) return -EFAULT; + if (id >= IB_UMAD_MAX_AGENTS) + return -EINVAL; mutex_lock(&file->port->file_mutex); mutex_lock(&file->mutex); - if (id >= IB_UMAD_MAX_AGENTS || !__get_agent(file, id)) { + id = array_index_nospec(id, IB_UMAD_MAX_AGENTS); + if (!__get_agent(file, id)) { ret = -EINVAL; goto out; } -- 2.20.1