From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F90C3A5A1 for ; Thu, 22 Aug 2019 17:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB866233FC for ; Thu, 22 Aug 2019 17:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495155; bh=DEa2f5Kl4GaZdgsTftJx7On0Vljmvv4AXnwwTBOYOWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bqR311C62cCgIFwLrq53eKVMRQAoMkpS32E+MrAgpvtHo+hyXJGCwvm+6P3tqr1XC FchiIzQdgSjhP1u0/LbWnYh4r7AnPmQodkdVxhjsTiz5Glyj/N8PktP2MhOItPMXLg LAr94vL0IIqTwHVC06PZJzc89zgaQK9BUb0sxVLs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392314AbfHVRce (ORCPT ); Thu, 22 Aug 2019 13:32:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:49786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404472AbfHVRZk (ORCPT ); Thu, 22 Aug 2019 13:25:40 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5F342341A; Thu, 22 Aug 2019 17:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494739; bh=DEa2f5Kl4GaZdgsTftJx7On0Vljmvv4AXnwwTBOYOWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rSxhDAJvd68T9H59wUXYXTkPqE5mQvbbPbWhIXqXiDPbpHWjnT1402rtzzF3UZnYQ 9GtFPF3kCTKi+4KDQ3NkSTQVJgB8NvcN5Lbs3keFyURsP8V2nm8qU6UE1QfsvjqlIT F77QqnWUTs4O+l4oosdIvL0tvKAVDmp6RUh1JOcw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vince Weaver , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.19 32/85] perf header: Fix divide by zero error if f_header.attr_size==0 Date: Thu, 22 Aug 2019 10:19:05 -0700 Message-Id: <20190822171732.744139636@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171731.012687054@linuxfoundation.org> References: <20190822171731.012687054@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 7622236ceb167aa3857395f9bdaf871442aa467e ] So I have been having lots of trouble with hand-crafted perf.data files causing segfaults and the like, so I have started fuzzing the perf tool. First issue found: If f_header.attr_size is 0 in the perf.data file, then perf will crash with a divide-by-zero error. Committer note: Added a pr_err() to tell the user why the command failed. Signed-off-by: Vince Weaver Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/alpine.DEB.2.21.1907231100440.14532@macbook-air Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/header.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index a94bd6850a0b2..4a5e1907a7ab3 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -3285,6 +3285,13 @@ int perf_session__read_header(struct perf_session *session) data->file.path); } + if (f_header.attr_size == 0) { + pr_err("ERROR: The %s file's attr size field is 0 which is unexpected.\n" + "Was the 'perf record' command properly terminated?\n", + data->file.path); + return -EINVAL; + } + nr_attrs = f_header.attrs.size / f_header.attr_size; lseek(fd, f_header.attrs.offset, SEEK_SET); -- 2.20.1