From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: James Clark <James.Clark@arm.com>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"alexey.budankov@linux.intel.com"
<alexey.budankov@linux.intel.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>, nd <nd@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Linton <Jeremy.Linton@arm.com>
Subject: Re: [PATCH] Fixes hang in zstd compression test by changing the source of random data.
Date: Thu, 22 Aug 2019 18:24:07 -0300 [thread overview]
Message-ID: <20190822212407.GJ3929@kernel.org> (raw)
In-Reply-To: <3d8cc701-df4e-f949-1715-5118b530e990@arm.com>
Em Thu, Aug 22, 2019 at 01:55:15PM +0000, James Clark escreveu:
> Running 'perf test' with zstd compression linked will hang at the test
> 'Zstd perf.data compression/decompression' because /dev/random blocks
> reads until there is enough entropy. This means that the test will
> appear to never complete unless the mouse is continually moved while
> running it.
message came mangled, had to do it by hand and then hook up your header
so as to get the correct date, attribution, etc, please check
Documentation/process/email-clients.rst,
- Arnaldo
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record+zstd_comp_decomp.sh b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> index 899604d1..63a91ec 100755
> --- a/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> +++ b/tools/perf/tests/shell/record+zstd_comp_decomp.sh
> @@ -13,7 +13,7 @@ skip_if_no_z_record() {
> collect_z_record() {
> echo "Collecting compressed record file:"
> $perf_tool record -o $trace_file -g -z -F 5000 -- \
> - dd count=500 if=/dev/random of=/dev/null
> + dd count=500 if=/dev/urandom of=/dev/null
> }
>
> check_compressed_stats() {
> --
> 2.7.4
>
--
- Arnaldo
next prev parent reply other threads:[~2019-08-22 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 13:55 [PATCH] Fixes hang in zstd compression test by changing the source of random data James Clark
2019-08-22 21:24 ` Arnaldo Carvalho de Melo [this message]
2019-08-22 21:24 ` Arnaldo Carvalho de Melo
2019-08-23 8:30 ` James Clark
2019-08-23 6:00 ` Alexey Budankov
2019-08-27 8:26 ` [tip: perf/core] perf tests: " tip-bot2 for James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822212407.GJ3929@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=James.Clark@arm.com \
--cc=Jeremy.Linton@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).