From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: yabinc@google.com, suzuki.poulose@arm.com, leo.yan@linaro.org
Cc: mike.leach@arm.com, alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] coresight: Add barrier packet when moving offset forward
Date: Thu, 22 Aug 2019 16:09:13 -0600 [thread overview]
Message-ID: <20190822220915.8876-1-mathieu.poirier@linaro.org> (raw)
Hi Yabin,
When doing more tests on your patch that adjust the offset to fit the
available space in the perf ring buffer[1], I noticed the decoder wasn't
able to decode the traces that had been collected. The issue was observed
in CPU wide scenarios but I also suspect they would have showed up in
per-thread mode given the right conditions.
I traced the problem to the moving forward of the offset in the trace
buffer. Doing so skips over the barrier packets originally inserted in
function tmc_sync_etr_buf(), which in turn prevents the decoder from
properly synchronising with the trace packets.
I fixed the condition by inserting barrier packets once the offset has been
moved forward, making sure that alignment rules are respected.
I'd be grateful if you could review and test my changes to make sure things
still work on your side.
Applies cleanly on the coresight next branch.
Best regards,
Mathieu
[1]. https://lkml.org/lkml/2019/8/14/1336
Mathieu Poirier (2):
coresight: tmc: Make memory width mask computation into a function
coresight: tmc-etr: Add barrier packet when moving offset forward
.../hwtracing/coresight/coresight-tmc-etf.c | 23 +---------
.../hwtracing/coresight/coresight-tmc-etr.c | 43 ++++++++++++++-----
drivers/hwtracing/coresight/coresight-tmc.c | 28 ++++++++++++
drivers/hwtracing/coresight/coresight-tmc.h | 1 +
4 files changed, 64 insertions(+), 31 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-22 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 22:09 Mathieu Poirier [this message]
2019-08-22 22:09 ` [PATCH 1/2] coresight: tmc: Make memory width mask computation into a function Mathieu Poirier
2019-08-22 22:09 ` [PATCH 2/2] coresight: tmc-etr: Add barrier packet when moving offset forward Mathieu Poirier
2019-08-23 8:22 ` Leo Yan
2019-08-26 17:24 ` [PATCH 2/2] coresight: " Yabin Cui
2019-08-24 0:30 ` [PATCH 0/2] " Yabin Cui
2019-08-26 14:59 ` Mathieu Poirier
2019-08-26 18:52 ` Yabin Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822220915.8876-1-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=yabinc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).