From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F30C3A5A2 for ; Sat, 24 Aug 2019 00:30:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07A8B20870 for ; Sat, 24 Aug 2019 00:30:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XV0kIGfN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbfHXAaJ (ORCPT ); Fri, 23 Aug 2019 20:30:09 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:52873 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbfHXAaI (ORCPT ); Fri, 23 Aug 2019 20:30:08 -0400 Received: by mail-pf1-f201.google.com with SMTP id a20so7621894pfn.19 for ; Fri, 23 Aug 2019 17:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=zkT1VJzOlMpr+PFhdjulVHmUztYGPpsUcL1mcrD/sx4=; b=XV0kIGfNLhFKDErAKV4H4RtNR00mLJJVXSCIWoEkw/0J2J6foBPWW7JP1DLkyJdJ4L kslBmPi0XhLhRoam2pwpXrta1dWTQ7E0fdwmqbqss+eWXhDlJPc3Fi4LlIXSZiFo/bst qPTbxxIAp5g0EF/0rDGLgJ3drfj00RbQvupJYLutusnyop98Z5bl9AUmCy/5uLG7jnrT WEhaEh5HdYmQzG6Jh4R7QXoWAfRasZfFn5EH3kbWZIwMNJW/EQKSQLWN9b0s1J0EiRLj 7mnEAq9of1Of2/H+G93xViCMwhHYB5b7V3wPJh49LbTX4J50fGbjmj0sp2XiR6RWkcSg 086w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=zkT1VJzOlMpr+PFhdjulVHmUztYGPpsUcL1mcrD/sx4=; b=iSSF021w7ifrjPyE5T1PR9nu3bjnv/3XWSMVyuSuv53KSY5QCF8/9RLJwf0xvXZeF/ PMewxX7bFaoDZgcMK9CKtwBZrQk/4h4h4oiUMTm4vGu7HTPDHfl/uuXE9n8KQFsK8tuK 7epWMP/3cYuQxad6GUPfodOgwosUipE7GSE+d8cj+77Z2Aa7eTNGFggteWbQGGI7L/jl 3ehnB8NenxhFlUg3H3kzssZ2xyWEEtmzn6xoaHyFgNd54PF+MFD3aUoqEAbsm/L3Fqbp nqEoiyQBuNMzoUySsmHGKtemJj4SqRRp6wI9xo3VA2TYMWrYWtrgGCUJ5OUaqdf6hAm4 2jcw== X-Gm-Message-State: APjAAAWHV/rfQQnXpm3R+ELacKAHpBr8PbLSPp8akmKRF7mAOkHWN8f6 +LvhKcZKSrkeV8o2IAuKBMh1MSznHA== X-Google-Smtp-Source: APXvYqyEOPLUtDizG8AcfA+fSIo2U88KPAd6cNLP0knFvcFoo7pvjTbOpThlzzU6BqduUVHTOxPE851nWlw= X-Received: by 2002:a65:65c5:: with SMTP id y5mr6171809pgv.342.1566606606983; Fri, 23 Aug 2019 17:30:06 -0700 (PDT) Date: Fri, 23 Aug 2019 17:30:02 -0700 In-Reply-To: <20190822220915.8876-1-mathieu.poirier@linaro.org> Message-Id: <20190824003002.87657-1-yabinc@google.com> Mime-Version: 1.0 References: <20190822220915.8876-1-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.23.0.187.g17f5b7556c-goog Subject: Re: [PATCH 0/2] coresight: Add barrier packet when moving offset forward From: Yabin Cui To: Mathieu Poirier , Suzuki K Poulose , leo.yan@linaro.org Cc: mike.leach@arm.com, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yabin Cui Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for fixing this problem. I didn't realize it because I usually use a buffer size >= the default ETR buffer size, which is harder to reproduce the problem. The patches LGTM, maybe you also want to fix the problem commented by Leo Yan. I tested the patches by recording etm data with a buffer size smaller than the default ETR buffer size. Then I saw barrier packets when decoding with OpenCSD. And I could decode successfully without error message.