From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E620C3A5A1 for ; Wed, 28 Aug 2019 17:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25B072077B for ; Wed, 28 Aug 2019 17:37:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nml2rPgz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfH1Rg0 (ORCPT ); Wed, 28 Aug 2019 13:36:26 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38961 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726876AbfH1RgX (ORCPT ); Wed, 28 Aug 2019 13:36:23 -0400 Received: by mail-pf1-f196.google.com with SMTP id y200so246802pfb.6 for ; Wed, 28 Aug 2019 10:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EUMK8UKoJN8MBf0J3kYsSiXaGWd4l00MuXQSkXHjEkU=; b=nml2rPgziIqKJ0ypA3HhZGv7pV0jpaWRM0sCJ9s6ye1Vt7mkf6Rl2xmGkJQg4ZnVF3 VhtIb7wJRRuVF8zrEpVU5NqQHImBtaOcva3nG2A6W77s4ijYRhKOQwwp4zqoxpw+Wcz2 C4mgd5vb4RlcMoNyuTQJNVLrpyoJm11W/LMtg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EUMK8UKoJN8MBf0J3kYsSiXaGWd4l00MuXQSkXHjEkU=; b=sB7eRTA0hn1R1BjM8tSHWLqt7w3WoLK/r0joHIWlcfM52d6Dt2stfU/lJwyaGguZx1 c5Ovz37gHptq7KXobNZ7W4plhgdW/sudSNa5+JOomOklfvNfvx/UxCU/iy4UsPReBbNo TwdBnX7UAp/ZUQvjfykmLYasBv04vTCZiEwrGM9l1BAffKHGXNj/JwDK+Fw1eknwWqRX 1ZmvIu6RU0F3v1QoXwcSXGd1fvzxFNYWzASdb4wbG9+/FCdNIiAsAVKfAvgzkAzjWVsU w2Vma4Pq/JGGXgMP2M5EtH4+7C0xk35vgdpV85T9OmG+0btMS/83Z2VvTg0TUjMgp2Ud KeaQ== X-Gm-Message-State: APjAAAVJXvURJM8nlwL0aZqAWMN2HcSCK+UqNfW6v900U5NL7r2NzFUJ 0iIv3e700aOo1vQS+mXDtkI0MQ== X-Google-Smtp-Source: APXvYqzElEqg+zkKsqa/GUFMyi2GafNnjd+E8JvecYKCOt+Q9UFz6HH9rmld8KOXaKUdBxtTP1/AiQ== X-Received: by 2002:a17:90a:17c4:: with SMTP id q62mr5279289pja.135.1567013783037; Wed, 28 Aug 2019 10:36:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j11sm3480331pfa.113.2019.08.28.10.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 10:36:20 -0700 (PDT) Date: Sat, 24 Aug 2019 12:08:00 -0700 From: Kees Cook To: Christophe Leroy Cc: Andrew Morton , 20190819234111.9019-8-keescook@chromium.org, Peter Zijlstra , Drew Davenport , Arnd Bergmann , "Steven Rostedt (VMware)" , Feng Tang , Petr Mladek , Mauro Carvalho Chehab , Borislav Petkov , YueHaibing , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler Message-ID: <201908241206.D223659@keescook> References: <201908200943.601DD59DCE@keescook> <20190822155611.a1a6e26db99ba0876ba9c8bd@linux-foundation.org> <86003539-18ec-f2ff-a46f-764edb820dcd@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86003539-18ec-f2ff-a46f-764edb820dcd@c-s.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 23, 2019 at 04:26:59PM +0200, Christophe Leroy wrote: > > > Le 23/08/2019 à 00:56, Andrew Morton a écrit : > > On Tue, 20 Aug 2019 09:47:55 -0700 Kees Cook wrote: > > > > > Reply-To: 20190819234111.9019-8-keescook@chromium.org > > > > Really? > > That seems correct, that's the "[PATCH 7/7] bug: Move WARN_ON() "cut here" > into exception handler" from the series at > https://lkml.org/lkml/2019/8/19/1155 > > > > > > > Subject: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler > > > > It's strange to receive a standalone [7/7] patch. > > Iaw the Reply_To, I understand it as an update of the 7th patch of the > series. Was trying to avoid the churn of resending the identical 1-6 patches (which are all just refactoring to make 7/7 not a mess). I can resend the whole series, if that's preferred. > > > Reported-by: Christophe Leroy > > > Fixes: Fixes: 6b15f678fb7d ("include/asm-generic/bug.h: fix "cut here" for WARN_ON for __WARN_TAINT architectures") > > > > I'm seeing double. Tracking down all these combinations has been tricky, which is why I did the patch 1-6 refactoring: it makes the call hierarchy much easier to examine (IMO). -Kees -- Kees Cook