From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E81C3A59E for ; Sat, 24 Aug 2019 20:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B618D206BB for ; Sat, 24 Aug 2019 20:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566680022; bh=48MYOIZuW/IlepkB5l0hqSY3B/k6uaeqevV8h/HJIN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=oFN8sfQqUNibJ2NqZ3+krXEEzCg5Pj4OAw75nn1N90uNauByAU88VJj5q1jYFnRw2 Q3kwZMvXJb07fUhorcNqz3QSFUlNGZYEnwLWQg9uymvBseD+1Bw0RmjOMQ+NAQwAtq 23dGpHD9BhC41W4/O7Ci/bo2328DNkCmd+8mxTGU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbfHXUxl (ORCPT ); Sat, 24 Aug 2019 16:53:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfHXUxl (ORCPT ); Sat, 24 Aug 2019 16:53:41 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EB61206BB; Sat, 24 Aug 2019 20:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566680020; bh=48MYOIZuW/IlepkB5l0hqSY3B/k6uaeqevV8h/HJIN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lyJvylBqRgh0nqZonlg1xatvHCEzJWQIjkGq8fNgwvLd6ZNxMSmv8fr/qxjFrnIzl 410SZHRsRSWG6wQJjxK4S1H03KH7TeFF9f25/Npu7w1bp/WbxOOqF1WEa/j+cyTc5O nWwFxni3w4f2v+KgMihb2OZ45d5S/sdqcJyfWUgg= Date: Sat, 24 Aug 2019 13:53:39 -0700 From: Andrew Morton To: Roman Gushchin Cc: "linux-mm@kvack.org" , Michal Hocko , Johannes Weiner , "linux-kernel@vger.kernel.org" , Kernel Team Subject: Re: [PATCH v3 0/3] vmstats/vmevents flushing Message-Id: <20190824135339.46da90b968d92529641b3ed2@linux-foundation.org> In-Reply-To: <20190823003347.GA4252@castle> References: <20190819230054.779745-1-guro@fb.com> <20190822162709.fa100ba6c58e15ea35670616@linux-foundation.org> <20190823003347.GA4252@castle> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Aug 2019 00:33:51 +0000 Roman Gushchin wrote: > On Thu, Aug 22, 2019 at 04:27:09PM -0700, Andrew Morton wrote: > > On Mon, 19 Aug 2019 16:00:51 -0700 Roman Gushchin wrote: > > > > > v3: > > > 1) rearranged patches [2/3] and [3/3] to make [1/2] and [2/2] suitable > > > for stable backporting > > > > > > v2: > > > 1) fixed !CONFIG_MEMCG_KMEM build by moving memcg_flush_percpu_vmstats() > > > and memcg_flush_percpu_vmevents() out of CONFIG_MEMCG_KMEM > > > 2) merged add-comments-to-slab-enums-definition patch in > > > > > > Thanks! > > > > > > Roman Gushchin (3): > > > mm: memcontrol: flush percpu vmstats before releasing memcg > > > mm: memcontrol: flush percpu vmevents before releasing memcg > > > mm: memcontrol: flush percpu slab vmstats on kmem offlining > > > > > > > Can you please explain why the first two patches were cc:stable but not > > the third? > > > > > > Because [1] and [2] are fixing commit 42a300353577 ("mm: memcontrol: fix > recursive statistics correctness & scalabilty"), which has been merged into 5.2. > > And [3] fixes commit fb2f2b0adb98 ("mm: memcg/slab: reparent memcg kmem_caches > on cgroup removal"), which is in not yet released 5.3, so stable backport isn't > required. OK, thanks. Patches 1 & 2 are good to go but I don't think that #3 has had suitable review and I have a note here that Michal has concerns with it.