linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	elder@kernel.org, johan@kernel.org, linux-kernel@vger.kernel.org,
	David Lin <dtwlin@gmail.com>
Subject: Re: [greybus-dev] [PATCH 5/9] staging: greybus: log: Fix up some alignment checkpatch issues
Date: Mon, 26 Aug 2019 11:42:35 +0530	[thread overview]
Message-ID: <20190826061235.u3chbbctniukjdys@vireshk-i7> (raw)
In-Reply-To: <20190825055429.18547-6-gregkh@linuxfoundation.org>

On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> Some function prototypes do not match the expected alignment formatting
> so fix that up so that checkpatch is happy.
> 
> Cc: David Lin <dtwlin@gmail.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: greybus-dev@lists.linaro.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/staging/greybus/log.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/log.c b/drivers/staging/greybus/log.c
> index 15a88574dbb0..4f1f161ff11c 100644
> --- a/drivers/staging/greybus/log.c
> +++ b/drivers/staging/greybus/log.c
> @@ -31,14 +31,14 @@ static int gb_log_request_handler(struct gb_operation *op)
>  	/* Verify size of payload */
>  	if (op->request->payload_size < sizeof(*receive)) {
>  		dev_err(dev, "log request too small (%zu < %zu)\n",
> -				op->request->payload_size, sizeof(*receive));
> +			op->request->payload_size, sizeof(*receive));
>  		return -EINVAL;
>  	}
>  	receive = op->request->payload;
>  	len = le16_to_cpu(receive->len);
>  	if (len != (op->request->payload_size - sizeof(*receive))) {
>  		dev_err(dev, "log request wrong size %d vs %zu\n", len,
> -				(op->request->payload_size - sizeof(*receive)));
> +			(op->request->payload_size - sizeof(*receive)));
>  		return -EINVAL;
>  	}
>  	if (len == 0) {
> @@ -83,7 +83,7 @@ static int gb_log_probe(struct gb_bundle *bundle,
>  		return -ENOMEM;
>  
>  	connection = gb_connection_create(bundle, le16_to_cpu(cport_desc->id),
> -			gb_log_request_handler);
> +					  gb_log_request_handler);
>  	if (IS_ERR(connection)) {
>  		retval = PTR_ERR(connection);
>  		goto error_free;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

  reply	other threads:[~2019-08-26  6:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25  5:54 [PATCH 0/9] staging: move greybus core out of staging Greg Kroah-Hartman
2019-08-25  5:54 ` [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files Greg Kroah-Hartman
2019-08-26  5:51   ` Viresh Kumar
2019-08-27  7:58     ` Greg Kroah-Hartman
2019-08-27  9:20       ` Gao Xiang
2019-08-27 15:43         ` Greg Kroah-Hartman
2019-08-27 16:01           ` Gao Xiang
2019-08-25  5:54 ` [PATCH 2/9] staging: greybus: remove license "boilerplate" Greg Kroah-Hartman
2019-08-26  5:52   ` Viresh Kumar
2019-08-27 15:37   ` Mark Greer
2019-08-25  5:54 ` [PATCH 3/9] staging: greybus: hd: Fix up some alignment checkpatch issues Greg Kroah-Hartman
2019-08-26  5:57   ` [greybus-dev] " Viresh Kumar
2019-08-25  5:54 ` [PATCH 4/9] staging: greybus: manifest: " Greg Kroah-Hartman
2019-08-26  6:11   ` [greybus-dev] " Viresh Kumar
2019-08-25  5:54 ` [PATCH 5/9] staging: greybus: log: " Greg Kroah-Hartman
2019-08-26  6:12   ` Viresh Kumar [this message]
2019-08-25  5:54 ` [PATCH 6/9] staging: greybus: loopback: " Greg Kroah-Hartman
2019-08-26  6:12   ` [greybus-dev] " Viresh Kumar
2019-08-25  5:54 ` [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/ Greg Kroah-Hartman
2019-08-26  5:55   ` Viresh Kumar
2019-08-27 15:38   ` Mark Greer
2019-08-25  5:54 ` [PATCH 8/9] staging: greybus: move the greybus core to drivers/greybus Greg Kroah-Hartman
2019-08-26  6:13   ` [greybus-dev] " Viresh Kumar
2019-08-25  5:54 ` [PATCH 9/9] staging: greybus: move es2 to drivers/greybus/ Greg Kroah-Hartman
2019-08-26  6:14   ` [greybus-dev] " Viresh Kumar
2019-08-27 10:43 ` [greybus-dev] [PATCH 0/9] staging: move greybus core out of staging Alex Elder
2019-08-27 13:36 ` Dan Carpenter
2019-08-27 13:45   ` Greg Kroah-Hartman
2019-08-27 14:30     ` Rui Miguel Silva
2019-08-27 15:43       ` Greg KH
2019-08-27 15:57         ` Rui Miguel Silva
2019-08-27 16:59           ` Greg KH
2019-08-27 14:37     ` Dan Carpenter
2019-09-01 17:23 ` Pavel Machek
2019-09-02  6:31   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826061235.u3chbbctniukjdys@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dtwlin@gmail.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).