Hi Geert. On Mon, Aug 26, 2019 at 09:28:56AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote: > > Add CMM units to Renesas R-Car M3-W device tree and reference them from > > the Display Unit they are connected to. > > > > Signed-off-by: Jacopo Mondi > > --- > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > index 3dc9d73f589a..8d78e1f98a23 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > @@ -2613,6 +2613,30 @@ > > renesas,fcp = <&fcpvi0>; > > }; > > > > + cmm0: cmm@fea40000 { > > + compatible = "renesas,cmm-r8a7796"; > > Shouldn't you add "renesas,rcar-gen3-cmm" as a fallback? Should I? Since you have suggested to drop all per-SoC compatibles from the driver I guess so... Thanks j > (for all CMM nodes in all DT patches) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds