From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77A8C3A59E for ; Mon, 26 Aug 2019 08:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6FA220874 for ; Mon, 26 Aug 2019 08:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730350AbfHZIB3 (ORCPT ); Mon, 26 Aug 2019 04:01:29 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38277 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfHZIB3 (ORCPT ); Mon, 26 Aug 2019 04:01:29 -0400 X-Originating-IP: 87.18.63.98 Received: from uno.localdomain (unknown [87.18.63.98]) (Authenticated sender: jacopo@jmondi.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id E4E4A1BF209; Mon, 26 Aug 2019 08:01:19 +0000 (UTC) Date: Mon, 26 Aug 2019 10:02:50 +0200 From: Jacopo Mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Laurent Pinchart , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List Subject: Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM Message-ID: <20190826080250.av3z2vunbd2z7hzu@uno.localdomain> References: <20190825135154.11488-1-jacopo+renesas@jmondi.org> <20190825135154.11488-9-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sbblrgvskuirlqsw" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sbblrgvskuirlqsw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Geert, On Mon, Aug 26, 2019 at 09:31:02AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:51 PM Jacopo Mondi wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > > to perform image enhancement and color correction. > > > > Add support for CMM through a driver that supports configuration of > > the 1-dimensional LUT table. More advanced CMM feature will be > > implemented on top of this basic one. > > > > Signed-off-by: Jacopo Mondi > > Thanks for your patch! > > > --- /dev/null > > +++ b/drivers/gpu/drm/rcar-du/rcar_cmm.c > > > +static const struct of_device_id rcar_cmm_of_table[] = { > > + { .compatible = "renesas,cmm-r8a7795", }, > > + { .compatible = "renesas,cmm-r8a7796", }, > > + { .compatible = "renesas,cmm-r8a77965", }, > > + { .compatible = "renesas,cmm-r8a77990", }, > > + { .compatible = "renesas,cmm-r8a77995", }, > > + { .compatible = "renesas,rcar-gen3-cmm", }, > > As they're all handled the same, you can drop the SoC-specific values > from the driver's match table. > > > + { .compatible = "renesas,rcar-gen2-cmm", }, > > Just wondering: has this been tested on R-Car Gen2? > Not from me :( It might not be the smartest move to add a compatible for an un-tested chip generation. I dragged the gen2 compatible in along the series as it was there in the downstream driver and I assumed BSP has been tested there, but since I've not been able to run any test on Gen2 board I should probably drop it? Any volunteer with a Gen2 board that want to run a test? Thanks j > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds --sbblrgvskuirlqsw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAl1jkioACgkQcjQGjxah Vjz2zA/9GA5pNTNrK1sLbSQr1l5T/m5J1t7HdVRkrl24WFP5Mpjzm1g/Du5cRFPQ XtI6YoSrvzWADCbeDldUaIGCQ+1b+EQntwVU3dkkV50FrxiDuZ+4b2+Qco1lTT9W 5uuWRkc14jpDdIT5bFYB79V4yckKLy54rzRHVgB5uX+KzswQgs26SICnlgecA+9d 7Dy6Q0gMVfnxrNiCSVrrr637sXfdKaQUAHz+y+X4bJTgQsjcjKD+WU4pqmG4hLs/ CsY9+FErIXk9yB2EOX7hCP6k6KsX/BHHRGW4uHq/neunFZECfDyI48yC/9qCWtWk JjZdAO+ZzPXFB1kjKeyfaunqa1oKhdR2C2traKN5E1i8EkRzTU1HB5CJElFDU5Xf OLOKApejqaZKSza693g9cU2Gv0UVO1jJuie2kEnp+5MH9BY+sJFxE47qmmdGeIlZ hIZ7X1A67eZD0z9FocQVpfBOLpztswaL3dNzOPw0azxdH4MgcTBoQYSFB/GVJLqS Az3r2R1w/kIDaJhmWNFLuPSiFJNdL1Sqrd/SChrQYoYbXGqqFE3O7a1TS+5k1tE+ ecLmjUPerqRP29vehz8lgipCdirotVmR+kCfGotGMnC6mpcqfR1WyghGLcl/nItc H78K5Xu8knqi0kV4ieP0PnIw60OC92IsceQBl3arkkrMkr/ukew= =MgVV -----END PGP SIGNATURE----- --sbblrgvskuirlqsw--