From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ICIc=WW=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AE589C3A5A5
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Aug 2019 08:55:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8FE57206BA
	for <linux-kernel@archiver.kernel.org>; Mon, 26 Aug 2019 08:55:01 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729872AbfHZIzA (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 26 Aug 2019 04:55:00 -0400
Received: from szxga03-in.huawei.com ([45.249.212.189]:3099 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726189AbfHZIzA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Aug 2019 04:55:00 -0400
Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57])
        by Forcepoint Email with ESMTP id AE4BCC525D72049DB0F0;
        Mon, 26 Aug 2019 16:54:56 +0800 (CST)
Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by
 DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 26 Aug 2019 16:54:55 +0800
Received: from architecture4 (10.140.130.215) by
 dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.1591.10; Mon, 26 Aug 2019 16:54:55 +0800
Date:   Mon, 26 Aug 2019 16:54:08 +0800
From:   Gao Xiang <gaoxiang25@huawei.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>, Greg KH <greg@kroah.com>
CC:     Linux Next Mailing List <linux-next@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Gao Xiang <hsiangkao@aol.com>, Chao Yu <yuchao0@huawei.com>
Subject: Re: linux-next: build warning after merge of the staging tree
Message-ID: <20190826085408.GB129185@architecture4>
References: <20190826063024.GA1217@kroah.com>
 <20190826083733.GA129185@architecture4>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20190826083733.GA129185@architecture4>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Originating-IP: [10.140.130.215]
X-ClientProxiedBy: dggeme706-chm.china.huawei.com (10.1.199.102) To
 dggeme762-chm.china.huawei.com (10.3.19.108)
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen,

On Mon, Aug 26, 2019 at 04:38:01PM +0800, Gao Xiang wrote:
> Hi Greg,
> 
> On Mon, Aug 26, 2019 at 08:30:24AM +0200, Greg KH wrote:
> > On Mon, Aug 26, 2019 at 04:24:32PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the staging tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > In file included from include/trace/events/erofs.h:8,
> > >                  from <command-line>:
> > > include/trace/events/erofs.h:28:37: warning: 'struct dentry' declared inside parameter list will not be visible outside of this definition or declaration
> > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > >                                      ^~~~~~
> > > include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
> > >   static inline void trace_##name(proto)    \
> > >                                   ^~~~~
> > > include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
> > >   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
> > >                         ^~~~~~
> > > include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
> > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > >   ^~~~~~~~~~~~~
> > > include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
> > >   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
> > >                       ^~~~~~
> > > include/trace/events/erofs.h:26:1: note: in expansion of macro 'TRACE_EVENT'
> > >  TRACE_EVENT(erofs_lookup,
> > >  ^~~~~~~~~~~
> > > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> > >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> > >   ^~~~~~~~
> > > 
> > > and moany more like this ...

Could you give me more log about this? I don't know how to reproduce that warning
since I can compile x86-64 kernel image with my configproperly on my PC...
I'm trying allmodconfig now...

Thanks,
Gao Xiang

> > > 
> > > Introduced by commit
> > > 
> > >   47e4937a4a7c ("erofs: move erofs out of staging")
> > > 
> > > (or, at least, exposed by it).  It needs, at least, a "struct dentry;"
> > > added to the file.
> > 
> > Odd, why has this never been seen before when the same files were in
> > drivers/staging/ and why 0-day isn't reporting this?
> 
> I Think it is weird since it is never failed in staging and kbuild-all 0-day ci
> (my tree and you tree)....
> 
> > 
> > Gao, can you send me a patch for this?
> 
> Got it, I will look into that...
> 
> Thanks,
> Gao Xiang
> 
> > 
> > thanks,
> > 
> > greg k-h