From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FEBC3A59F for ; Mon, 26 Aug 2019 16:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9E802173E for ; Mon, 26 Aug 2019 16:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732709AbfHZQUZ (ORCPT ); Mon, 26 Aug 2019 12:20:25 -0400 Received: from muru.com ([72.249.23.125]:58680 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731965AbfHZQUZ (ORCPT ); Mon, 26 Aug 2019 12:20:25 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6611780AA; Mon, 26 Aug 2019 16:20:53 +0000 (UTC) Date: Mon, 26 Aug 2019 09:20:21 -0700 From: Tony Lindgren To: Masahiro Yamada Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Message-ID: <20190826162021.GW52127@atomide.com> References: <20190823025808.11875-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823025808.11875-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Masahiro Yamada [190822 19:59]: > is only generated and included by > arch/arm/mach-omap2/, so it does not need to reside in the globally > visible include/generated/. > > I renamed it to arch/arm/mach-omap2/pm-asm-offsets.h since the prefix > 'ti-' is just redundant in mach-omap2/. > > My main motivation of this change is to avoid the race condition for > the parallel build (-j) when CONFIG_IKHEADERS is enabled. > > When it is enabled, all the headers under include/ are archived into > kernel/kheaders_data.tar.xz and exposed in the sysfs. > > In the parallel build, we have no idea in which order files are built. > > - If ti-pm-asm-offsets.h is built before kheaders_data.tar.xz, > the header will be included in the archive. Probably nobody will > use it, but it is harmless except that it will increase the archive > size needlessly. > > - If kheaders_data.tar.xz is built before ti-pm-asm-offsets.h, > the header will not be included in the archive. However, in the next > build, the archive will be re-generated to include the newly-found > ti-pm-asm-offsets.h. This is not nice from the build system point > of view. > > - If ti-pm-asm-offsets.h and kheaders_data.tar.xz are built at the > same time, the corrupted header might be included in the archive, > which does not look nice either. > > This commit fixes the race. > > Signed-off-by: Masahiro Yamada > Tested-by: Keerthy Applying into omap-for-v5.4/soc thanks. The commit is on top of v5.3-rc1 so it can be merged into other branches if needed after it's been sitting in Linux next for few days with no issues. Regards, Tony