From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F183FC3A5A3 for ; Tue, 27 Aug 2019 07:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7DE2186A for ; Tue, 27 Aug 2019 07:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892336; bh=ojC/UGNlNugB3a4nyj6dXP2tDgWTltx02sMqfuw2wis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0AabNs5MOSmObMPAU0xd70HcjaDwjF2ltTF+hTsQhK4UySqOTZIrEe5y94vYZLURq nQQ3RSju885550pcp6nk9vbPsH8v1w3WPboaZoETTaSQ+Ri4Mh2KnYyYO7rMe4boce lxiNrUGbNnPpjL1BXGnNl3TufXZBXk/LeuC4AF34= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729364AbfH0HwP (ORCPT ); Tue, 27 Aug 2019 03:52:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:43438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbfH0HwK (ORCPT ); Tue, 27 Aug 2019 03:52:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEB7F2173E; Tue, 27 Aug 2019 07:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892330; bh=ojC/UGNlNugB3a4nyj6dXP2tDgWTltx02sMqfuw2wis=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xkp4HX6nGq1vxw+AHOYsa57k1wZwmHMIcZFip7iania2fy5d7Xz9zyI2GnbT74TIp Lb2MW4w36R8MdcP8cVocYySqJtJqYOSNQmSQ/WoKBPyvOFrOQsLm6LmzTsW2iuawY/ 0qofpibI4DogeZhz1DoRV/QAZ29UQq7wqjxUZyG0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wang Xiayang , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 4.14 19/62] can: peak_usb: force the string buffer NULL-terminated Date: Tue, 27 Aug 2019 09:50:24 +0200 Message-Id: <20190827072701.449299878@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072659.803647352@linuxfoundation.org> References: <20190827072659.803647352@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit e787f19373b8a5fa24087800ed78314fd17b984a ] strncpy() does not ensure NULL-termination when the input string size equals to the destination buffer size IFNAMSIZ. The output string is passed to dev_info() which relies on the NULL-termination. Use strlcpy() instead. This issue is identified by a Coccinelle script. Signed-off-by: Wang Xiayang Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c index d68c79f9a4b95..059282a6065c6 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c @@ -881,7 +881,7 @@ static void peak_usb_disconnect(struct usb_interface *intf) dev_prev_siblings = dev->prev_siblings; dev->state &= ~PCAN_USB_STATE_CONNECTED; - strncpy(name, netdev->name, IFNAMSIZ); + strlcpy(name, netdev->name, IFNAMSIZ); unregister_netdev(netdev); -- 2.20.1