From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E6A3C3A5A3 for ; Tue, 27 Aug 2019 08:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54B3E2186A for ; Tue, 27 Aug 2019 08:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893715; bh=wmFpTMDmsRASVLtfJC54RKuVGJYmDT4P4EllHugwNwI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JPfpndmJBJ/bOJMaAUB7ClTXDDP3LrD4sPhzKoNZGafhaMIT5q5z5AfJWsPtAGsOe TYP2h6RBHLB6lruJ1TsO0uiDBeLDVUFzPFMoF/Dzqb4l36nwYhi9zpha4M+5QbJBIo zES4WudwC2Dzk2ccwkXA1Hn/rv5x+KQOCC0kvch8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731634AbfH0IPO (ORCPT ); Tue, 27 Aug 2019 04:15:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:47738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729585AbfH0Hzu (ORCPT ); Tue, 27 Aug 2019 03:55:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 86B15217F5; Tue, 27 Aug 2019 07:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892550; bh=wmFpTMDmsRASVLtfJC54RKuVGJYmDT4P4EllHugwNwI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YVc4C0uOesN+JTmE4nXy77GPDT4mtli1xfSr/sUnOZgBBLZ8IpeZQXdkK2pUJKSyO UX2YmozrQs5S5lPTkAVIEEHYNesly2WWArUSy7jOXsSBsMFVB50hFYvYw8JSfD++04 qMjAX6/kdNifbG0obM0byWBZOC483lBwocWo1aek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wang Xiayang , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 4.19 31/98] can: sja1000: force the string buffer NULL-terminated Date: Tue, 27 Aug 2019 09:50:10 +0200 Message-Id: <20190827072719.820113845@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072718.142728620@linuxfoundation.org> References: <20190827072718.142728620@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit cd28aa2e056cd1ea79fc5f24eed0ce868c6cab5c ] strncpy() does not ensure NULL-termination when the input string size equals to the destination buffer size IFNAMSIZ. The output string 'name' is passed to dev_info which relies on NULL-termination. Use strlcpy() instead. This issue is identified by a Coccinelle script. Signed-off-by: Wang Xiayang Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/sja1000/peak_pcmcia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/sja1000/peak_pcmcia.c b/drivers/net/can/sja1000/peak_pcmcia.c index b8c39ede7cd51..179bfcd541f2f 100644 --- a/drivers/net/can/sja1000/peak_pcmcia.c +++ b/drivers/net/can/sja1000/peak_pcmcia.c @@ -487,7 +487,7 @@ static void pcan_free_channels(struct pcan_pccard *card) if (!netdev) continue; - strncpy(name, netdev->name, IFNAMSIZ); + strlcpy(name, netdev->name, IFNAMSIZ); unregister_sja1000dev(netdev); -- 2.20.1