From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3EECC3A5A3 for ; Tue, 27 Aug 2019 08:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB033206BA for ; Tue, 27 Aug 2019 08:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893116; bh=qxtuKSUg3eurnCP7YIA3t2QLRNZ0xE9YzzYPXHpgpbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MY7OHdefJqtYWkNaPmnVNouXGCA/3erDcqEOtON1jbuoY4V00rGxxD1YweHrEFOvj K10n3RQ3repyK1SuOWIVje9hxuLempz5AdBdP9FUId97yPBFc5InTuAAIUgwQtkQnO mCGa0aT8RSsrrW8sRJ4zWvfq7CMqzHC4UQeLhOh0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732286AbfH0IFP (ORCPT ); Tue, 27 Aug 2019 04:05:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:34786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731410AbfH0IFJ (ORCPT ); Tue, 27 Aug 2019 04:05:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 245F52173E; Tue, 27 Aug 2019 08:05:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893108; bh=qxtuKSUg3eurnCP7YIA3t2QLRNZ0xE9YzzYPXHpgpbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fwJxMuYnOgILVt/ikzjio/YV/G2Lkcg4EC6imd2tZGMtpg2Cy4zwrTGkQztzGE9Ax HLFpGmAXT6M7J4U4WkxniNwzVAgvH4LRxWzrWjSPm67RgVS7tSFDCiFeEToH1S8leJ qZO+gkI1Gg2FicY0ReGjV1Q+ugMyfTLjSur+P0PQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Kelley , Dexuan Cui , Sasha Levin , Juliana Rodrigueiro Subject: [PATCH 5.2 123/162] Drivers: hv: vmbus: Fix virt_to_hvpfn() for X86_PAE Date: Tue, 27 Aug 2019 09:50:51 +0200 Message-Id: <20190827072742.758392913@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072738.093683223@linuxfoundation.org> References: <20190827072738.093683223@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui commit a9fc4340aee041dd186d1fb8f1b5d1e9caf28212 upstream. In the case of X86_PAE, unsigned long is u32, but the physical address type should be u64. Due to the bug here, the netvsc driver can not load successfully, and sometimes the VM can panic due to memory corruption (the hypervisor writes data to the wrong location). Fixes: 6ba34171bcbd ("Drivers: hv: vmbus: Remove use of slow_virt_to_phys()") Cc: stable@vger.kernel.org Cc: Michael Kelley Reported-and-tested-by: Juliana Rodrigueiro Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/hv/channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -26,7 +26,7 @@ static unsigned long virt_to_hvpfn(void *addr) { - unsigned long paddr; + phys_addr_t paddr; if (is_vmalloc_addr(addr)) paddr = page_to_phys(vmalloc_to_page(addr)) +