From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2974C41514 for ; Tue, 27 Aug 2019 13:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A4F02054F for ; Tue, 27 Aug 2019 13:36:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="G72/sLBI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729484AbfH0Ng3 (ORCPT ); Tue, 27 Aug 2019 09:36:29 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56338 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfH0Ng2 (ORCPT ); Tue, 27 Aug 2019 09:36:28 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7RDYd2V195703; Tue, 27 Aug 2019 13:36:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=RfJyOS5EC0GN/YwO4IHH9U9alxOQgZ3re2Bes/V6CM8=; b=G72/sLBIlmGT4TQGE5hkM7efp+GdnUDogn65wdcZtMST8Oz35lnzFbJ9xabqyS3Sruaf OLf0n9BhjzsoJZG0kvCXLuu0rqah7Ipzj+HTMh67MF0sd4a3qbDapQC0rNxEfYX5nHbB OC7bJ5w1H2b4v7dMV9M7xDCwoOkb/C4J7YyTZ8ReHFwgV6xhXyW+yQp6/HavhyB26jtr uQR09TYrlhhcAA3cSLuZoZm/DZDxWVxiu6z7cDIrXxmTB10AwyjDxvEZlB9Xxlhbd7wd lN/pHFzH5ncv+E8kk+21BYdRwjDqnleZ/cp+OFQ5+7SlDLu+UCpABiNMXPi3E7hcd6sr SA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2un551g73h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2019 13:36:22 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7RDXrFQ121925; Tue, 27 Aug 2019 13:36:21 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2umhu8rpgx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2019 13:36:21 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7RDaKSZ008735; Tue, 27 Aug 2019 13:36:20 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Aug 2019 06:36:20 -0700 Date: Tue, 27 Aug 2019 16:36:11 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, elder@kernel.org, johan@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] staging: move greybus core out of staging Message-ID: <20190827133611.GE23584@kadam> References: <20190825055429.18547-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190825055429.18547-1-gregkh@linuxfoundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9361 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908270146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9361 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908270146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I can't compile greybus so it's hard to run Smatch on it... I have a Smatch thing which ignores missing includes and just tries its best. It mostly generates garbage output but a couple of these look like potential issues: drivers/staging/greybus/operation.c:379 gb_operation_message_alloc() warn: check 'message_size' for integer overflows 'kzalloc()' drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->channels' double freed drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->name' double freed regards, dan carpenter