From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 345DBC3A5A3 for ; Tue, 27 Aug 2019 16:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15F5721881 for ; Tue, 27 Aug 2019 16:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730108AbfH0QlM (ORCPT ); Tue, 27 Aug 2019 12:41:12 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52634 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727401AbfH0QlL (ORCPT ); Tue, 27 Aug 2019 12:41:11 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7RGeCWG021084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2019 12:40:13 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 70A4F42049E; Tue, 27 Aug 2019 12:40:12 -0400 (EDT) Date: Tue, 27 Aug 2019 12:40:12 -0400 From: "Theodore Y. Ts'o" To: "boojin.kim" Cc: "'Satya Tangirala'" , "'Herbert Xu'" , "'David S. Miller'" , "'Eric Biggers'" , "'Chao Yu'" , "'Jaegeuk Kim'" , "'Andreas Dilger'" , dm-devel@redhat.com, "'Mike Snitzer'" , "'Alasdair Kergon'" , "'Jens Axboe'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Jaehoon Chung'" , "'Ulf Hansson'" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 5/9] block: support diskcipher Message-ID: <20190827164012.GN28066@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , "boojin.kim" , 'Satya Tangirala' , 'Herbert Xu' , "'David S. Miller'" , 'Eric Biggers' , 'Chao Yu' , 'Jaegeuk Kim' , 'Andreas Dilger' , dm-devel@redhat.com, 'Mike Snitzer' , 'Alasdair Kergon' , 'Jens Axboe' , 'Krzysztof Kozlowski' , 'Kukjin Kim' , 'Jaehoon Chung' , 'Ulf Hansson' , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org References: <03b201d55cb2$1d4d31b0$57e79510$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03b201d55cb2$1d4d31b0$57e79510$@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 27, 2019 at 05:33:33PM +0900, boojin.kim wrote: > > Dear Satya. > Keyslot manager is a good solution for ICE. And probably no issue for FMP. > But, I think it's complicated for FMP because FMP doesn't need > any keyslot control. Hi Boojin, I think the important thing to realize here is that there are a large number of hardware devices for which the keyslot manager *is* needed. And from the upstream kernel's perspective, supporting two different schemes for supporting the inline encryption feature is more complexity than just supporting one which is general enough to support a wider variety of hardware devices. If you want somethig which is only good for the hardware platform you are charged to support, that's fine if it's only going to be in a Samsung-specific kernel. But if your goal is to get something that works upstream, especially if it requires changes in core layers of the kernel, it's important that it's general enough to support most, if not all, if the hardware devices in the industry. Regards, - Ted