Hi Stephen, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc6 next-20190827] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/clk-Evict-unregistered-clks-from-parent-caches/20190827-165138 config: mips-allnoconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/clk/clk.c: In function 'clk_core_evict_parent_cache': >> drivers/clk/clk.c:3785:15: error: 'all_lists' undeclared (first use in this function); did you mean 'lists'? for (lists = all_lists; *lists; lists++) ^~~~~~~~~ lists drivers/clk/clk.c:3785:15: note: each undeclared identifier is reported only once for each function it appears in vim +3785 drivers/clk/clk.c 3776 3777 /* Remove this clk from all parent caches */ 3778 static void clk_core_evict_parent_cache(struct clk_core *core) 3779 { 3780 struct hlist_head **lists; 3781 struct clk_core *root; 3782 3783 lockdep_assert_held(&prepare_lock); 3784 > 3785 for (lists = all_lists; *lists; lists++) 3786 hlist_for_each_entry(root, *lists, child_node) 3787 clk_core_evict_parent_cache_subtree(root, core); 3788 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation