From: Rob Herring <robh@kernel.org>
To: Vinod Koul <vkoul@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, spapothi@codeaurora.org,
bgoswami@codeaurora.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [RESEND PATCH v4 1/4] dt-bindings: soundwire: add slave bindings
Date: Tue, 27 Aug 2019 15:20:22 -0500 [thread overview]
Message-ID: <20190827202022.GA7783@bogus> (raw)
In-Reply-To: <20190823065340.GD2672@vkoul-mobl>
On Fri, Aug 23, 2019 at 12:23:40PM +0530, Vinod Koul wrote:
> On 23-08-19, 00:37, Srinivas Kandagatla wrote:
> > This patch adds bindings for Soundwire Slave devices that includes how
> > SoundWire enumeration address and Link ID are used to represented in
> > SoundWire slave device tree nodes.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > ---
> > .../soundwire/soundwire-controller.yaml | 75 +++++++++++++++++++
> > 1 file changed, 75 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml b/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml
> > new file mode 100644
> > index 000000000000..91aa6c6d6266
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml
> > @@ -0,0 +1,75 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soundwire/soundwire-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SoundWire Controller Generic Binding
>
> Controller does not make sense here, why not use spec terminology and
> say "SoundWire Slave Generic Binding"
It's both IMO. It's describing the structure of child devices of a
controller (aka a bus).
>
> > +
> > +maintainers:
> > + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > +
> > +description: |
> > + SoundWire busses can be described with a node for the SoundWire controller
> > + device and a set of child nodes for each SoundWire slave on the bus.
> > +
> > +properties:
> > + $nodename:
> > + pattern: "^soundwire(@.*|-[0-9a-f])*$"
'-[0-9a-f]' was to handle cases like spi-gpio or i2c-gpio. Would a
bit banged interface be possible here?
> > +
> > + "#address-cells":
> > + const: 2
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > +patternProperties:
> > + "^.*@[0-9a-f]+$":
If there are distinct fields in the address, they are typically comma
separated in the unit-address.
> > + type: object
> > +
> > + properties:
> > + compatible:
> > + pattern: "^sdw[0-9][0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$"
> > + description:
> > + Is the textual representation of SoundWire Enumeration
> > + address. compatible string should contain SoundWire Version ID,
> > + Manufacturer ID, Part ID and Class ID in order and shall be in
> > + lower-case hexadecimal with leading zeroes.
> > + Valid sizes of these fields are
> > + Version ID is 1 nibble, number '0x1' represents SoundWire 1.0
> > + and '0x2' represents SoundWire 1.1 and so on.
> > + MFD is 4 nibbles
> > + PID is 4 nibbles
> > + CID is 2 nibbles
> > + More Information on detail of encoding of these fields can be
> > + found in MIPI Alliance DisCo & SoundWire 1.0 Specifications.
> > +
> > + reg:
> > + maxItems: 1
> > + description:
> > + Instance ID and Link ID of SoundWire Device Address.
>
> This looks better :) Thanks.
>
> Apart from the minor nit above this looks good to me, I can merge the
> sdw parts if Rob is fine with them.
>
> Thanks
>
> > +
> > + required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + soundwire@c2d0000 {
> > + #address-cells = <2>;
> > + #size-cells = <0>;
> > + compatible = "qcom,soundwire-v1.5.0";
This will probably change once I review it. :)
> > + reg = <0x0c2d0000 0x2000>;
> > +
> > + speaker@1 {
> > + compatible = "sdw10217201000";
> > + reg = <1 0>;
> > + };
> > +
> > + speaker@2 {
> > + compatible = "sdw10217201000";
> > + reg = <2 0>;
> > + };
> > + };
> > +
> > +...
> > --
> > 2.21.0
>
> --
> ~Vinod
next prev parent reply other threads:[~2019-08-27 20:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 23:37 [RESEND PATCH v4 0/4] ASoC: codecs: Add WSA881x Smart Speaker amplifier support Srinivas Kandagatla
2019-08-22 23:37 ` [RESEND PATCH v4 1/4] dt-bindings: soundwire: add slave bindings Srinivas Kandagatla
2019-08-23 6:53 ` Vinod Koul
2019-08-27 20:20 ` Rob Herring [this message]
2019-08-27 20:28 ` Srinivas Kandagatla
2019-08-23 15:41 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-23 15:57 ` Srinivas Kandagatla
2019-08-23 16:44 ` Pierre-Louis Bossart
2019-08-24 9:28 ` Srinivas Kandagatla
2019-08-26 16:22 ` Pierre-Louis Bossart
2019-08-27 21:21 ` Srinivas Kandagatla
2019-08-22 23:37 ` [RESEND PATCH v4 2/4] soundwire: core: add device tree support for slave devices Srinivas Kandagatla
2019-08-23 15:44 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-23 15:47 ` Srinivas Kandagatla
2019-08-22 23:37 ` [RESEND PATCH v4 3/4] dt-bindings: ASoC: Add WSA881x bindings Srinivas Kandagatla
2019-08-27 12:20 ` Rob Herring
2019-08-27 20:25 ` Srinivas Kandagatla
2019-08-22 23:37 ` [RESEND PATCH v4 4/4] ASoC: codecs: add wsa881x amplifier support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827202022.GA7783@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).