From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3 0/2] r8152: fix side effect
Date: Tue, 27 Aug 2019 21:17:35 -0700 [thread overview]
Message-ID: <20190827211735.269764fb@cakuba.netronome.com> (raw)
In-Reply-To: <1394712342-15778-320-Taiwan-albertk@realtek.com>
On Wed, 28 Aug 2019 09:51:40 +0800, Hayes Wang wrote:
> v3:
> Update the commit message for patch #1.
>
> v2:
> Replace patch #2 with "r8152: remove calling netif_napi_del".
>
> v1:
> The commit 0ee1f4734967 ("r8152: napi hangup fix after disconnect")
> add a check to avoid using napi_disable after netif_napi_del. However,
> the commit ffa9fec30ca0 ("r8152: set RTL8152_UNPLUG only for real
> disconnection") let the check useless.
>
> Therefore, I revert commit 0ee1f4734967 ("r8152: napi hangup fix
> after disconnect") first, and add another patch to fix it.
LGTM, seems like if we were to add a Fixes tag it'd point to the
ffa9fec30ca0 ("r8152: set RTL8152_UNPLUG only for real disconnection")
commit, then? So only net needs it, v5.2 is fine.
next prev parent reply other threads:[~2019-08-28 4:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 8:53 [PATCH net 0/2] r8152: fix side effect Hayes Wang
2019-08-23 8:53 ` [PATCH net 1/2] Revert "r8152: napi hangup fix after disconnect" Hayes Wang
2019-08-23 8:53 ` [PATCH net 2/2] r8152: avoid using napi_disable after netif_napi_del Hayes Wang
2019-08-23 21:33 ` David Miller
2019-08-28 1:51 ` [PATCH net v3 0/2] r8152: fix side effect Hayes Wang
2019-08-28 1:51 ` [PATCH net v3 1/2] Revert "r8152: napi hangup fix after disconnect" Hayes Wang
2019-08-28 1:51 ` [PATCH net v3 2/2] r8152: remove calling netif_napi_del Hayes Wang
2019-08-28 4:17 ` Jakub Kicinski [this message]
2019-08-28 23:02 ` [PATCH net v3 0/2] r8152: fix side effect David Miller
2019-08-28 12:56 ` [PATCH net v4 " Hayes Wang
2019-08-28 12:56 ` [PATCH net v4 1/2] Revert "r8152: napi hangup fix after disconnect" Hayes Wang
2019-08-28 12:56 ` [PATCH net v4 2/2] r8152: remove calling netif_napi_del Hayes Wang
2019-08-28 23:17 ` [PATCH net v4 0/2] r8152: fix side effect David Miller
2019-08-29 1:08 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827211735.269764fb@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).