From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>, Minchan Kim <minchan@kernel.org>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: linux-next: Tree for Aug 27 (mm/zsmalloc.c)
Date: Wed, 28 Aug 2019 14:30:41 +0900 [thread overview]
Message-ID: <20190828053041.GC526@jagdpanzerIV> (raw)
In-Reply-To: <895d0324-3537-3d36-fa0f-5d61b733ef6e@infradead.org>
On (08/27/19 08:37), Randy Dunlap wrote:
> on x86_64:
>
> In file included from ../include/linux/mmzone.h:10:0,
> from ../include/linux/gfp.h:6,
> from ../include/linux/umh.h:4,
> from ../include/linux/kmod.h:9,
> from ../include/linux/module.h:13,
> from ../mm/zsmalloc.c:33:
> ../mm/zsmalloc.c: In function ‘zs_create_pool’:
> ../mm/zsmalloc.c:2416:27: error: ‘struct zs_pool’ has no member named ‘migration_wait’
> init_waitqueue_head(&pool->migration_wait);
> ^
> ../include/linux/wait.h:67:26: note: in definition of macro ‘init_waitqueue_head’
> __init_waitqueue_head((wq_head), #wq_head, &__key); \
> ^~~~~~~
Thanks.
I believe akpm has a patch for that build error.
===========
--- a/mm/zsmalloc.c~mm-zsmallocc-fix-build-when-config_compaction=n
+++ a/mm/zsmalloc.c
@@ -2412,7 +2412,9 @@ struct zs_pool *zs_create_pool(const cha
if (!pool->name)
goto err;
+#ifdef CONFIG_COMPACTION
init_waitqueue_head(&pool->migration_wait);
+#endif
===========
-ss
next prev parent reply other threads:[~2019-08-28 5:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:05 linux-next: Tree for Aug 27 Stephen Rothwell
2019-08-27 15:18 ` linux-next: Tree for Aug 27 (amdgpu) Randy Dunlap
2019-08-27 15:41 ` Alex Deucher
2019-08-27 15:24 ` linux-next: Tree for Aug 27 (mshyperv.c) Randy Dunlap
2019-08-27 15:29 ` linux-next: Tree for Aug 27 (kunit) Randy Dunlap
2019-08-27 16:09 ` Brendan Higgins
2019-08-27 16:12 ` shuah
2019-08-27 15:37 ` linux-next: Tree for Aug 27 (mm/zsmalloc.c) Randy Dunlap
2019-08-28 5:30 ` Sergey Senozhatsky [this message]
2019-08-27 15:40 ` linux-next: Tree for Aug 27 (objtool) Randy Dunlap
2019-08-27 15:59 ` Josh Poimboeuf
2019-08-27 19:05 ` Randy Dunlap
2019-08-28 15:51 ` Josh Poimboeuf
2019-08-28 16:05 ` Randy Dunlap
2019-08-28 16:13 ` Josh Poimboeuf
2019-08-28 16:34 ` Josh Poimboeuf
2019-08-29 1:53 ` Masami Hiramatsu
2019-08-29 17:59 ` Josh Poimboeuf
2019-08-30 6:23 ` Masami Hiramatsu
2019-08-30 15:14 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828053041.GC526@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).