From: Borislav Petkov <bp@alien8.de>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro
Date: Wed, 28 Aug 2019 08:42:31 +0200 [thread overview]
Message-ID: <20190828064231.GB4920@zn.tnic> (raw)
In-Reply-To: <20190828061100.27032-1-caoj.fnst@cn.fujitsu.com>
On Wed, Aug 28, 2019 at 02:11:00PM +0800, Cao jin wrote:
For the future:
> Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro
your subject needs to have a verb and start with a capital letter after
the subsystem/path prefix. In this case, something like this, for
example:
Subject: [PATCH] x86/cpufeature: Explain the macro duplication
> Help people to understand the author's intent of apparent duplication of
> BUILD_BUG_ON_ZERO(NCAPINTS != n), which is hard to detect by eyes.
>
> CC: Dave Hansen <dave.hansen@intel.com>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> Tried my best to describe it accurately, in case of any inaccuracy, feel
> free to rephrase.
Yap, I fixed it up.
Thanks!
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-08-28 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 6:11 [PATCH] x86/cpufeature: explicit comments for duplicate macro Cao jin
2019-08-28 6:42 ` Borislav Petkov [this message]
2019-08-28 8:16 ` Cao jin
2019-08-28 6:49 ` [tip: x86/cleanups] x86/cpufeature: Explain the macro duplication tip-bot2 for Cao Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828064231.GB4920@zn.tnic \
--to=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).