From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67928C3A5A6 for ; Wed, 28 Aug 2019 13:39:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4852120828 for ; Wed, 28 Aug 2019 13:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfH1Nja convert rfc822-to-8bit (ORCPT ); Wed, 28 Aug 2019 09:39:30 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53103 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbfH1Nja (ORCPT ); Wed, 28 Aug 2019 09:39:30 -0400 X-Originating-IP: 90.30.228.116 Received: from windsurf.home (atoulouse-659-1-185-116.w90-30.abo.wanadoo.fr [90.30.228.116]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E361220009; Wed, 28 Aug 2019 13:39:27 +0000 (UTC) Date: Wed, 28 Aug 2019 15:39:26 +0200 From: Thomas Petazzoni To: Krzysztof Wilczynski Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] PCI: Move static keyword to the front of declarations in pci-bridge-emul.c Message-ID: <20190828153926.1d8d9d7b@windsurf.home> In-Reply-To: <20190828131733.5817-1-kw@linux.com> References: <20190826151436.4672-1-kw@linux.com> <20190828131733.5817-1-kw@linux.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, 28 Aug 2019 15:17:33 +0200 Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations of > pci_regs_behavior and pcie_cap_regs_behavior, and resolve > the following compiler warning that can be seen when > building with warnings enabled (W=1): > > drivers/pci/pci-bridge-emul.c:41:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] > const static struct pci_bridge_reg_behavior pci_regs_behavior[] = { > ^ > drivers/pci/pci-bridge-emul.c:176:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] > const static struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = { > ^ > > Signed-off-by: Krzysztof Wilczynski Acked-by: Thomas Petazzoni Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com