From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7AFC3A5A6 for ; Wed, 28 Aug 2019 16:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF4442173E for ; Wed, 28 Aug 2019 16:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726569AbfH1QNf (ORCPT ); Wed, 28 Aug 2019 12:13:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55768 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbfH1QNf (ORCPT ); Wed, 28 Aug 2019 12:13:35 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 458FA8AC6F9; Wed, 28 Aug 2019 16:13:35 +0000 (UTC) Received: from treble (ovpn-121-55.rdu2.redhat.com [10.10.121.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E2055D6B0; Wed, 28 Aug 2019 16:13:33 +0000 (UTC) Date: Wed, 28 Aug 2019 11:13:31 -0500 From: Josh Poimboeuf To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Peter Zijlstra Subject: Re: linux-next: Tree for Aug 27 (objtool) Message-ID: <20190828161331.kvikro257blxtzu5@treble> References: <20190827190526.6f27e763@canb.auug.org.au> <6c42e32f-901d-be78-e69b-cb9ff8703932@infradead.org> <20190827155911.ct2zzo2zhcrauf3z@treble> <2e8b18a0-a09c-b67e-c99f-45066ab9d511@infradead.org> <20190828155147.v6eowc7rr7upr7dr@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Wed, 28 Aug 2019 16:13:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 28, 2019 at 09:05:18AM -0700, Randy Dunlap wrote: > On 8/28/19 8:51 AM, Josh Poimboeuf wrote: > > On Tue, Aug 27, 2019 at 12:05:42PM -0700, Randy Dunlap wrote: > >> On 8/27/19 8:59 AM, Josh Poimboeuf wrote: > >>> On Tue, Aug 27, 2019 at 08:40:07AM -0700, Randy Dunlap wrote: > >>>> On 8/27/19 2:05 AM, Stephen Rothwell wrote: > >>>>> Hi all, > >>>>> > >>>>> Changes since 20190826: > >>>>> > >>>> > >>>> on x86_64: > >>>> > >>>> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_handle_exit_irqoff()+0x33: unreachable instruction > >>>> > >>>>> gcc --version > >>>> gcc (SUSE Linux) 7.4.0 > >>>> > >>>> > >>>> want more info? > >>> > >>> Yes, can you provide the .o and the .config? > >>> > >> > >> Sure. The .o was 508KB, so I compressed it. > > > > Thanks Randy. Here's a tentative fix. I need to make sure it doesn't > > break anything else. > > Works for me on the reported failure. Thanks. > > Acked-by: Randy Dunlap Turns out this patch does break something: arch/x86/xen/enlighten_pv.o: warning: objtool: xen_cpuid()+0x25: can't find jump dest instruction at .text+0x9c I'll need to figure out a better way to whitelist that XEN_EMULATE_PREFIX fake instruction thing. I'll probably just teach the objtool decoder about it. -- Josh