* [PATCH v2 0/2] mbox changes for QCS404 DVFS
@ 2019-08-29 8:27 Jorge Ramirez-Ortiz
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-29 8:27 ` [PATCH v2 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
0 siblings, 2 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-08-29 8:27 UTC (permalink / raw)
To: jorge.ramirez-ortiz, sboyd, agross, jassisinghbrar
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
These are the mailbox changes required to enable CPU frequency scaling on
Qualcomm's QCS404.
v2: sboyd review
replace if statement with a of_match_device
dont modify platform_set_drvdata
Jorge Ramirez-Ortiz (2):
mbox: qcom: add APCS child device for QCS404
mbox: qcom: replace integer with valid macro
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
--
2.22.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404
2019-08-29 8:27 [PATCH v2 0/2] mbox changes for QCS404 DVFS Jorge Ramirez-Ortiz
@ 2019-08-29 8:27 ` Jorge Ramirez-Ortiz
2019-08-29 13:59 ` Bjorn Andersson
2019-08-29 14:56 ` Stephen Boyd
2019-08-29 8:27 ` [PATCH v2 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
1 sibling, 2 replies; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-08-29 8:27 UTC (permalink / raw)
To: jorge.ramirez-ortiz, sboyd, agross, jassisinghbrar
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
There is clock controller functionality in the APCS hardware block of
qcs404 devices similar to msm8916.
Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 705e17a5479c..d3676fd3cf94 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -47,7 +47,6 @@ static const struct mbox_chan_ops qcom_apcs_ipc_ops = {
static int qcom_apcs_ipc_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
struct qcom_apcs_ipc *apcs;
struct regmap *regmap;
struct resource *res;
@@ -55,6 +54,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
void __iomem *base;
unsigned long i;
int ret;
+ const struct of_device_id apcs_clk_match_table[] = {
+ { .compatible = "qcom,msm8916-apcs-kpss-global", },
+ { .compatible = "qcom,qcs404-apcs-apps-global", },
+ {}
+ };
apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL);
if (!apcs)
@@ -89,7 +93,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
return ret;
}
- if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
+ if (of_match_device(apcs_clk_match_table, &pdev->dev)) {
apcs->clk = platform_device_register_data(&pdev->dev,
"qcom-apcs-msm8916-clk",
-1, NULL, 0);
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] mbox: qcom: replace integer with valid macro
2019-08-29 8:27 [PATCH v2 0/2] mbox changes for QCS404 DVFS Jorge Ramirez-Ortiz
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
@ 2019-08-29 8:27 ` Jorge Ramirez-Ortiz
2019-08-29 14:56 ` Stephen Boyd
1 sibling, 1 reply; 6+ messages in thread
From: Jorge Ramirez-Ortiz @ 2019-08-29 8:27 UTC (permalink / raw)
To: jorge.ramirez-ortiz, sboyd, agross, jassisinghbrar
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
Use the correct macro when registering the platform device.
Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index d3676fd3cf94..7870edb4405b 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -96,7 +96,8 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
if (of_match_device(apcs_clk_match_table, &pdev->dev)) {
apcs->clk = platform_device_register_data(&pdev->dev,
"qcom-apcs-msm8916-clk",
- -1, NULL, 0);
+ PLATFORM_DEVID_NONE,
+ NULL, 0);
if (IS_ERR(apcs->clk))
dev_err(&pdev->dev, "failed to register APCS clk\n");
}
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
@ 2019-08-29 13:59 ` Bjorn Andersson
2019-08-29 14:56 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2019-08-29 13:59 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz
Cc: sboyd, agross, jassisinghbrar, niklas.cassel, linux-arm-msm,
linux-kernel
On Thu 29 Aug 01:27 PDT 2019, Jorge Ramirez-Ortiz wrote:
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Nice, I like this version.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index 705e17a5479c..d3676fd3cf94 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -47,7 +47,6 @@ static const struct mbox_chan_ops qcom_apcs_ipc_ops = {
>
> static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> {
> - struct device_node *np = pdev->dev.of_node;
> struct qcom_apcs_ipc *apcs;
> struct regmap *regmap;
> struct resource *res;
> @@ -55,6 +54,11 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> void __iomem *base;
> unsigned long i;
> int ret;
> + const struct of_device_id apcs_clk_match_table[] = {
> + { .compatible = "qcom,msm8916-apcs-kpss-global", },
> + { .compatible = "qcom,qcs404-apcs-apps-global", },
> + {}
> + };
>
> apcs = devm_kzalloc(&pdev->dev, sizeof(*apcs), GFP_KERNEL);
> if (!apcs)
> @@ -89,7 +93,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
> + if (of_match_device(apcs_clk_match_table, &pdev->dev)) {
> apcs->clk = platform_device_register_data(&pdev->dev,
> "qcom-apcs-msm8916-clk",
> -1, NULL, 0);
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-29 13:59 ` Bjorn Andersson
@ 2019-08-29 14:56 ` Stephen Boyd
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-08-29 14:56 UTC (permalink / raw)
To: agross, jassisinghbrar, jorge.ramirez-ortiz
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
Quoting Jorge Ramirez-Ortiz (2019-08-29 01:27:58)
> There is clock controller functionality in the APCS hardware block of
> qcs404 devices similar to msm8916.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] mbox: qcom: replace integer with valid macro
2019-08-29 8:27 ` [PATCH v2 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
@ 2019-08-29 14:56 ` Stephen Boyd
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-08-29 14:56 UTC (permalink / raw)
To: agross, jassisinghbrar, jorge.ramirez-ortiz
Cc: niklas.cassel, bjorn.andersson, linux-arm-msm, linux-kernel
Quoting Jorge Ramirez-Ortiz (2019-08-29 01:27:59)
> Use the correct macro when registering the platform device.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-29 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 8:27 [PATCH v2 0/2] mbox changes for QCS404 DVFS Jorge Ramirez-Ortiz
2019-08-29 8:27 ` [PATCH v2 1/2] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-08-29 13:59 ` Bjorn Andersson
2019-08-29 14:56 ` Stephen Boyd
2019-08-29 8:27 ` [PATCH v2 2/2] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-08-29 14:56 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).