From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF2BC3A59F for ; Thu, 29 Aug 2019 10:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 589212073F for ; Thu, 29 Aug 2019 10:28:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I/bTPQ8R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbfH2K2w (ORCPT ); Thu, 29 Aug 2019 06:28:52 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56100 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfH2K2w (ORCPT ); Thu, 29 Aug 2019 06:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CDQv3og0UHxZ8vB+W50a7E0hCQ70tmtKnd44IXZRO7w=; b=I/bTPQ8RCf8zjKa1/9w6Dg0Au 8CT1NhvbPHzlLq9A4A6MS5qrSb4cArkSEJJmndaErf+jxuwohcpeC/0KFBuQkWgTgtYhZQUvt2ShJ A99zZunMfEuwcyXnF3oyU63S1t6NYuUeGjjvCLhmYqJKy/VSNHBAoewNsS6ouZWtzGBYJY/1t9GUE 5PNjTnhT0pxt0ukc0WatR2xMwj3N8gLTRE+TXBo0L47Ke5LAkd7pza4dG8LmUZPXQmg7DLGvYqPQF H0XiYwNorBcLaSFmPVQtQQ1W7pE+0bGZhGs6o6FErUOmZ0c+GwdG90l9SLrWnhLMY4o0y1HGfuuRy A1JPuzUuQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3HfS-00005P-Hh; Thu, 29 Aug 2019 10:28:38 +0000 Date: Thu, 29 Aug 2019 03:28:38 -0700 From: Christoph Hellwig To: Gao Xiang Cc: Alexander Viro , Greg Kroah-Hartman , Andrew Morton , Stephen Rothwell , Theodore Ts'o , Pavel Machek , David Sterba , Amir Goldstein , Christoph Hellwig , "Darrick J . Wong" , Dave Chinner , Jaegeuk Kim , Jan Kara , Linus Torvalds , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, LKML , linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , Li Guifu , Fang Wei Subject: Re: [PATCH v6 08/24] erofs: add namei functions Message-ID: <20190829102838.GG20598@infradead.org> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190802125347.166018-9-gaoxiang25@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802125347.166018-9-gaoxiang25@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 02, 2019 at 08:53:31PM +0800, Gao Xiang wrote: > +struct erofs_qstr { > + const unsigned char *name; > + const unsigned char *end; > +}; Maybe erofs_name? The q in qstr stands for quick, because of the existing hash and len, which this doesn't really provide. Also I don't really see why you don't just pass the actual qstr and just document that dirnamecmp does not look at the hash and thus doesn't require it to be filled out.