From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7728C3A59F for ; Thu, 29 Aug 2019 12:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C457C2339E for ; Thu, 29 Aug 2019 12:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbfH2MhW (ORCPT ); Thu, 29 Aug 2019 08:37:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:39552 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727014AbfH2MhW (ORCPT ); Thu, 29 Aug 2019 08:37:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EE906AC67; Thu, 29 Aug 2019 12:37:20 +0000 (UTC) Date: Thu, 29 Aug 2019 14:37:16 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Arnd Bergmann Cc: David Hildenbrand , Heiko Carstens , David Howells , Paul Mackerras , Breno Leitao , Michael Neuling , Geert Uytterhoeven , Allison Randal , Firoz Khan , Joel Stanley , Nicolai Stange , Nicholas Piggin , Thomas Gleixner , Christian Brauner , Greg Kroah-Hartman , Linux Kernel Mailing List , "Eric W. Biederman" , Andrew Donnellan , Hari Bathini , linuxppc-dev Subject: Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only. Message-ID: <20190829143716.6e41b10e@naga> In-Reply-To: References: <061a0de2042156669303f95526ec13476bf490c7.1567072270.git.msuchanek@suse.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Aug 2019 14:19:46 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 12:23 PM Michal Suchanek wrote: > > > > Fixes: aff850393200 ("powerpc: add system call table generation support") > > This patch needs a proper explanation. The Fixes tag doesn't seem right > here, since ppc64 has had llseek since the start in 2002 commit 3939e37587e7 > ("Add ppc64 support. This includes both pSeries (RS/6000) and iSeries > (AS/400)."). > > > diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl > > index 010b9f445586..53e427606f6c 100644 > > --- a/arch/powerpc/kernel/syscalls/syscall.tbl > > +++ b/arch/powerpc/kernel/syscalls/syscall.tbl > > @@ -188,7 +188,7 @@ > > 137 common afs_syscall sys_ni_syscall > > 138 common setfsuid sys_setfsuid > > 139 common setfsgid sys_setfsgid > > -140 common _llseek sys_llseek > > +140 32 _llseek sys_llseek > > 141 common getdents sys_getdents compat_sys_getdents > > 142 common _newselect sys_select compat_sys_select > > 143 common flock sys_flock > > In particular, I don't see why you single out llseek here, but leave other > syscalls that are not needed on 64-bit machines such as pread64(). Because llseek is not built in fs/ when building 64bit only causing a link error. I initially posted patch to build it always but it was pointed out it is not needed, and the interface does not make sense on 64bit, and that platforms that don't have it on 64bit now don't want that useless code. Thanks Michal