From: Marcelo Tosatti <mtosatti@redhat.com>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Sean Christopherson" <sean.j.christopherson@intel.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Wanpeng Li" <wanpengli@tencent.com>,
"Jim Mattson" <jmattson@google.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v1] cpuidle-haltpoll: vcpu hotplug support
Date: Thu, 29 Aug 2019 11:40:14 -0300 [thread overview]
Message-ID: <20190829144011.GA14365@amt.cnet> (raw)
In-Reply-To: <311c2ffe-f840-9990-c1a7-5561cc5a0f54@oracle.com>
On Thu, Aug 29, 2019 at 03:24:31PM +0100, Joao Martins wrote:
> On 8/29/19 2:50 PM, Joao Martins wrote:
> > On 8/29/19 12:56 PM, Marcelo Tosatti wrote:
> >> Hi Joao,
> >>
> >> On Wed, Aug 28, 2019 at 07:56:50PM +0100, Joao Martins wrote:
> >>> +static void haltpoll_uninit(void)
> >>> +{
> >>> + unsigned int cpu;
> >>> +
> >>> + cpus_read_lock();
> >>> +
> >>> + for_each_online_cpu(cpu) {
> >>> + struct cpuidle_device *dev =
> >>> + per_cpu_ptr(haltpoll_cpuidle_devices, cpu);
> >>> +
> >>> + if (!dev->registered)
> >>> + continue;
> >>> +
> >>> + arch_haltpoll_disable(cpu);
> >>> + cpuidle_unregister_device(dev);
> >>> + }
> >>
> >> 1)
> >>
> >>> +
> >>> + cpuidle_unregister(&haltpoll_driver);
> >>
> >> cpuidle_unregister_driver.
> >
> > Will fix -- this was an oversight.
> >
> >>
> >>> + free_percpu(haltpoll_cpuidle_devices);
> >>> + haltpoll_cpuidle_devices = NULL;
> >>> +
> >>> + cpus_read_unlock();
> >>
> >> Any reason you can't cpus_read_unlock() at 1) ?
> >>
> > No, let me adjust that too.
> >
> >> Looks good otherwise.
> >>
>
> BTW, should I take this as a Acked-by, Reviewed-by, or neither? :)
>
> Joao
I'll ACK -v2 once you send it.
prev parent reply other threads:[~2019-08-29 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 18:56 [PATCH v1] cpuidle-haltpoll: vcpu hotplug support Joao Martins
2019-08-28 23:39 ` Rafael J. Wysocki
2019-08-29 11:56 ` Marcelo Tosatti
2019-08-29 13:50 ` Joao Martins
2019-08-29 14:24 ` Joao Martins
2019-08-29 14:40 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829144011.GA14365@amt.cnet \
--to=mtosatti@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=jmattson@google.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).